[cros New-GAIA] Fix load animation.

[cros New-GAIA] Fix load animation.
Drop 'show' class when needed.
Add showView message guard to prevent cases when message is
not received.

BUG=466348
Committed: https://crrev.com/f6c09395474c82e35afebd2e247f80a6cb17e282
Cr-Commit-Position: refs/heads/master@{#326295}

[Nikita (slow), 2015-04-10 13:15:50]

nkostylev@chromium.org changed reviewers:
+ dzhioev@chromium.org

[Nikita (slow), 2015-04-10 13:16:01]

The CQ bit was checked by nkostylev@chromium.org to run a CQ dry run

[Nikita (slow), 2015-04-10 13:43:09]

The CQ bit was checked by nkostylev@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-04-10 13:43:45]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1074183002/20001

[commit-bot: I haz the power, 2015-04-10 13:52:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-10 13:52:55]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[dzhioev (left Google), 2015-04-13 15:18:28]

https://codereview.chromium.org/1074183002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/chromeos/login/screen_gaia_signin.js (right):

https://codereview.chromium.org/1074183002/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/screen_gaia_signin.js:278:
window.clearTimeout(this.loadAnimationGuardTimer_);
Just |clearTimeout| without window.

https://codereview.chromium.org/1074183002/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/screen_gaia_signin.js:289:
this.loadAnimationGuardTimer_ = window.setTimeout(
Drop window.

https://codereview.chromium.org/1074183002/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/screen_gaia_signin.js:559: onShowView_:
function(e) {
Try to switch 'loading' state and focus webview in this method, instead of
onAuthReady_

[Nikita (slow), 2015-04-22 13:11:17]

nkostylev@chromium.org changed reviewers:
+ dpolukhin@chromium.org

[Nikita (slow), 2015-04-22 13:11:18]

+Dmitry please review

https://codereview.chromium.org/1074183002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/chromeos/login/screen_gaia_signin.js (right):

https://codereview.chromium.org/1074183002/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/screen_gaia_signin.js:278:
window.clearTimeout(this.loadAnimationGuardTimer_);
On 2015/04/13 15:18:28, dzhioev wrote:
> Just |clearTimeout| without window.

Done.

https://codereview.chromium.org/1074183002/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/screen_gaia_signin.js:289:
this.loadAnimationGuardTimer_ = window.setTimeout(
On 2015/04/13 15:18:28, dzhioev wrote:
> Drop window.

Done.

https://codereview.chromium.org/1074183002/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/screen_gaia_signin.js:559: onShowView_:
function(e) {
On 2015/04/13 15:18:28, dzhioev wrote:
> Try to switch 'loading' state and focus webview in this method, instead of
> onAuthReady_

Try that and there's a degraded UX since user is able to see field w/o focus for
a short period of time.

[Dmitry Polukhin, 2015-04-22 13:17:52]

lgtm

https://codereview.chromium.org/1074183002/diff/40001/chrome/browser/resource...
File chrome/browser/resources/chromeos/login/screen_gaia_signin.js (right):

https://codereview.chromium.org/1074183002/diff/40001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/screen_gaia_signin.js:559: if
(!this.isNewGaiaFlow) {
nit, i would extract this part to separate function and call it here and in
onShowView_.

[Nikita (slow), 2015-04-22 13:55:24]

https://codereview.chromium.org/1074183002/diff/40001/chrome/browser/resource...
File chrome/browser/resources/chromeos/login/screen_gaia_signin.js (right):

https://codereview.chromium.org/1074183002/diff/40001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/screen_gaia_signin.js:559: if
(!this.isNewGaiaFlow) {
On 2015/04/22 13:17:51, Dmitry Polukhin wrote:
> nit, i would extract this part to separate function and call it here and in
> onShowView_.

Done.

[Nikita (slow), 2015-04-22 13:55:55]

The CQ bit was checked by nkostylev@chromium.org

[Nikita (slow), 2015-04-22 13:55:55]

The patchset sent to the CQ was uploaded after l-g-t-m from
dpolukhin@chromium.org
Link to the patchset: https://codereview.chromium.org/1074183002/#ps60001
(title: "refactor")

[commit-bot: I haz the power, 2015-04-22 13:56:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1074183002/60001

[commit-bot: I haz the power, 2015-04-22 14:40:14]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-04-22 14:41:05]

Patchset 4 (id:??) landed as
https://crrev.com/f6c09395474c82e35afebd2e247f80a6cb17e282
Cr-Commit-Position: refs/heads/master@{#326295}