Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1074143002: Use cctest to track memory stats for isolate and context. (Closed)

Created:
5 years, 8 months ago by Yang
Modified:
5 years, 8 months ago
Reviewers:
Michael Achenbach
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Use cctest to track memory stats for isolate and context. R=machenbach@chromium.org Committed: https://crrev.com/88630d4e54aa7423590694799b75e8668570ade5 Cr-Commit-Position: refs/heads/master@{#27754}

Patch Set 1 #

Patch Set 2 : remove .gitignore entry #

Patch Set 3 : small tweak #

Patch Set 4 : disable always-opt #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -4 lines) Patch
M .gitignore View 1 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/test-serialize.cc View 1 2 3 1 chunk +8 lines, -0 lines 0 comments Download
M test/memory/Memory.json View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
Yang
5 years, 8 months ago (2015-04-10 11:56:27 UTC) #1
Michael Achenbach
lgtm + removal of the .gitignore
5 years, 8 months ago (2015-04-10 11:59:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1074143002/20001
5 years, 8 months ago (2015-04-10 11:59:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1074143002/40001
5 years, 8 months ago (2015-04-10 12:01:04 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_arm64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel/builds/4660)
5 years, 8 months ago (2015-04-10 12:45:57 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1074143002/60001
5 years, 8 months ago (2015-04-10 13:10:48 UTC) #14
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 8 months ago (2015-04-10 14:13:27 UTC) #15
commit-bot: I haz the power
5 years, 8 months ago (2015-04-10 14:13:39 UTC) #16
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/88630d4e54aa7423590694799b75e8668570ade5
Cr-Commit-Position: refs/heads/master@{#27754}

Powered by Google App Engine
This is Rietveld 408576698