Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(434)

Issue 1074133002: Remove Type::Array bit and replace with Type::GlobalObject (Closed)

Created:
5 years, 8 months ago by titzer
Modified:
5 years, 8 months ago
Reviewers:
rossberg
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove Type::Array bit and replace with Type::GlobalObject R=rossberg@chromium.org BUG= Committed: https://crrev.com/277be506c81421cce9462702d0700cc29127844f Cr-Commit-Position: refs/heads/master@{#27749}

Patch Set 1 #

Patch Set 2 : Rebase on splitting of type tests. #

Total comments: 4

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+119 lines, -47 lines) Patch
M src/hydrogen-types.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/types.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/types.cc View 1 2 3 chunks +4 lines, -4 lines 0 comments Download
M src/typing.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-types.cc View 1 14 chunks +111 lines, -39 lines 0 comments Download
M test/cctest/types-fuzz.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
titzer
5 years, 8 months ago (2015-04-10 08:56:23 UTC) #1
rossberg
LGTM modulo comments https://codereview.chromium.org/1074133002/diff/20001/src/types.cc File src/types.cc (right): https://codereview.chromium.org/1074133002/diff/20001/src/types.cc#newcode252 src/types.cc:252: case JS_ARRAY_TYPE: Nit: just include this ...
5 years, 8 months ago (2015-04-10 11:41:56 UTC) #2
titzer
https://codereview.chromium.org/1074133002/diff/20001/src/types.cc File src/types.cc (right): https://codereview.chromium.org/1074133002/diff/20001/src/types.cc#newcode252 src/types.cc:252: case JS_ARRAY_TYPE: On 2015/04/10 11:41:55, rossberg wrote: > Nit: ...
5 years, 8 months ago (2015-04-10 12:35:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1074133002/40001
5 years, 8 months ago (2015-04-10 12:41:43 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 8 months ago (2015-04-10 13:29:41 UTC) #7
commit-bot: I haz the power
5 years, 8 months ago (2015-04-10 13:29:55 UTC) #8
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/277be506c81421cce9462702d0700cc29127844f
Cr-Commit-Position: refs/heads/master@{#27749}

Powered by Google App Engine
This is Rietveld 408576698