Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Issue 107413007: Add new accessibility_unittests target to "try" and "fyi" (Closed)

Created:
6 years, 11 months ago by dmazzoni
Modified:
6 years, 10 months ago
CC:
chromium-reviews, cmp-cc_chromium.org, kjellander+cc_chromium.org, xusydoc+watch_chromium.org, ilevy-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Visibility:
Public.

Description

Add new accessibility_unittests target to "try" and "fyi" Eventually we want accessibility_unittests everywhere that content_unittests is currently run, because they target the same platforms and configurations. These tests are fast, safe to shard, and should run on all platforms other than iOS. Please double-check carefully and assume I don't know what I'm doing. BUG=322537 R=stip@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=242950

Patch Set 1 #

Patch Set 2 : tryserver and fyi only #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -2 lines) Patch
M masters/master.chromium.fyi/master.cfg View 1 8 chunks +10 lines, -2 lines 0 comments Download
M masters/master.chromium.fyi/master_win_asan_cfg.py View 1 chunk +1 line, -0 lines 0 comments Download
M masters/master.tryserver.chromium/master.cfg View 12 chunks +12 lines, -0 lines 0 comments Download
M scripts/master/factory/chromium_factory.py View 1 chunk +4 lines, -0 lines 1 comment Download

Messages

Total messages: 10 (0 generated)
dmazzoni
6 years, 11 months ago (2014-01-03 17:48:14 UTC) #1
ghost stip (do not use)
Can you split out the FYI and trybot changes? We can land these separately, then ...
6 years, 11 months ago (2014-01-03 19:40:50 UTC) #2
dmazzoni
On 2014/01/03 19:40:50, stip wrote: > Can you split out the FYI and trybot changes? ...
6 years, 11 months ago (2014-01-03 22:15:13 UTC) #3
ghost stip (do not use)
lgtm. note that the _br versions of the tests should go live once this CL ...
6 years, 11 months ago (2014-01-03 22:37:45 UTC) #4
dmazzoni
Committed patchset #2 manually as r242950 (presubmit successful).
6 years, 11 months ago (2014-01-03 22:46:32 UTC) #5
James Cook
https://codereview.chromium.org/107413007/diff/50001/scripts/master/factory/chromium_factory.py File scripts/master/factory/chromium_factory.py (right): https://codereview.chromium.org/107413007/diff/50001/scripts/master/factory/chromium_factory.py#newcode340 scripts/master/factory/chromium_factory.py:340: f.AddBuildrunnerGTest('accessibility_unittests_br', fp) I think this might be a typo.
6 years, 11 months ago (2014-01-14 16:41:11 UTC) #6
ghost stip (do not use)
indeed it is!
6 years, 11 months ago (2014-01-14 22:24:36 UTC) #7
Elliot Glaysher
On 2014/01/14 22:24:36, stip wrote: > indeed it is! So is this typo responsible for ...
6 years, 11 months ago (2014-01-15 21:30:38 UTC) #8
ghost stip (do not use)
yes, the fix is in https://chromiumcodereview.appspot.com/135153004/
6 years, 11 months ago (2014-01-15 21:32:52 UTC) #9
earthdok
6 years, 10 months ago (2014-02-21 17:06:49 UTC) #10
Message was sent while issue was closed.
It's not correct to add tests to the trybot (linux_asan) without simultaneously
adding them to the corresponding waterfall bot. If anyone breaks those tests,
the sheriffs will have no way of knowing and the trybot will just stay red.

Powered by Google App Engine
This is Rietveld 408576698