Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2537)

Unified Diff: chrome/browser/content_settings/permission_request_id.h

Issue 107413006: Dismiss EME infobar when WebMediaPlayer is destroyed. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: #if defined(OS_ANDROID) Created 6 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/content_settings/permission_request_id.h
diff --git a/chrome/browser/content_settings/permission_request_id.h b/chrome/browser/content_settings/permission_request_id.h
index 14bc2742ef36c6f38a8afafe13e62010cab02ec8..425a5228bb161c087e98ba51bb044cbd5546b740 100644
--- a/chrome/browser/content_settings/permission_request_id.h
+++ b/chrome/browser/content_settings/permission_request_id.h
@@ -10,12 +10,16 @@
// Uniquely identifies a particular permission request.
class PermissionRequestID {
public:
- PermissionRequestID(int render_process_id, int render_view_id, int bridge_id);
+ PermissionRequestID(int render_process_id,
+ int render_view_id,
+ int bridge_id,
+ int group_id);
~PermissionRequestID();
int render_process_id() const { return render_process_id_; }
int render_view_id() const { return render_view_id_; }
int bridge_id() const { return bridge_id_; }
+ int group_id() const { return group_id_; }
bool Equals(const PermissionRequestID& other) const;
bool IsForSameTabAs(const PermissionRequestID& other) const;
@@ -24,7 +28,13 @@ class PermissionRequestID {
private:
int render_process_id_;
int render_view_id_;
+ // Id unique to this instance.
int bridge_id_;
+ // Id possibly shared by multiple instance. This is used in
+ // PermissionQueueController::CancelInfoBarRequests(int group_id) to cancel
+ // multiple permission requests by a group id. If you don't use that function,
+ // this doesn't matter and setting this to 0 is recommended.
+ int group_id_;
markusheintz_ 2014/01/07 12:22:45 Would be great to add one sentence about when this
Kibeom Kim (inactive) 2014/01/07 19:31:24 Done.
// Purposefully do not disable copying, as this is stored in STL containers.
};

Powered by Google App Engine
This is Rietveld 408576698