content/common/media/media_player_messages_android.h - Issue 107413006: Dismiss EME infobar when WebMediaPlayer is destroyed.

Side by Side Diff: content/common/media/media_player_messages_android.h

Issue 107413006: Dismiss EME infobar when WebMediaPlayer is destroyed. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« content/browser/media/android/browser_media_player_manager.cc ('K') | « content/browser/media/android/browser_media_player_manager.cc ('k') | content/public/browser/browser_context.h » ('j') | content/renderer/media/android/proxy_media_keys.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 // IPC messages for android media player.	5 // IPC messages for android media player.

6 // Multiply-included message file, hence no include guard.	6 // Multiply-included message file, hence no include guard.

7	7

8 #include <string>	8 #include <string>

9 #include <vector>	9 #include <vector>

10	10

(...skipping 284 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
295	295

296 IPC_MESSAGE_ROUTED3(MediaKeysHostMsg_UpdateSession,	296 IPC_MESSAGE_ROUTED3(MediaKeysHostMsg_UpdateSession,

297 int /* media_keys_id */,	297 int /* media_keys_id */,

298 uint32_t /* session_id */,	298 uint32_t /* session_id */,

299 std::vector<uint8> /* response */)	299 std::vector<uint8> /* response */)

300	300

301 IPC_MESSAGE_ROUTED2(MediaKeysHostMsg_ReleaseSession,	301 IPC_MESSAGE_ROUTED2(MediaKeysHostMsg_ReleaseSession,

302 int /* media_keys_id */,	302 int /* media_keys_id */,

303 uint32_t /* session_id */)	303 uint32_t /* session_id */)

304	304

	305 IPC_MESSAGE_ROUTED2(MediaKeysHostMsg_CancelSession,
	ddorwin 2013/12/20 23:59:52 ditto ditto Kibeom Kim (inactive) 2013/12/30 12:33:05 Done. Show quoted text On 2013/12/20 23:59:52, ddorwin wrote: > ditto Done.
	306 int /* media_keys_id */,

	307 uint32_t /* session_id */)

	308

305 IPC_MESSAGE_ROUTED3(MediaKeysMsg_SessionCreated,	309 IPC_MESSAGE_ROUTED3(MediaKeysMsg_SessionCreated,

306 int /* media_keys_id */,	310 int /* media_keys_id */,

307 uint32_t /* session_id */,	311 uint32_t /* session_id */,

308 std::string /* web_session_id */)	312 std::string /* web_session_id */)

309	313

310 IPC_MESSAGE_ROUTED4(MediaKeysMsg_SessionMessage,	314 IPC_MESSAGE_ROUTED4(MediaKeysMsg_SessionMessage,

311 int /* media_keys_id */,	315 int /* media_keys_id */,

312 uint32_t /* session_id */,	316 uint32_t /* session_id */,

313 std::vector<uint8> /* message */,	317 std::vector<uint8> /* message */,

314 std::string /* destination_url */)	318 std::string /* destination_url */)

315 // TODO(jrummell): Use GURL for destination_url (http://crbug.com/326663)	319 // TODO(jrummell): Use GURL for destination_url (http://crbug.com/326663)

316	320

317 IPC_MESSAGE_ROUTED2(MediaKeysMsg_SessionReady,	321 IPC_MESSAGE_ROUTED2(MediaKeysMsg_SessionReady,

318 int /* media_keys_id */,	322 int /* media_keys_id */,

319 uint32_t /* session_id */)	323 uint32_t /* session_id */)

320	324

321 IPC_MESSAGE_ROUTED2(MediaKeysMsg_SessionClosed,	325 IPC_MESSAGE_ROUTED2(MediaKeysMsg_SessionClosed,

322 int /* media_keys_id */,	326 int /* media_keys_id */,

323 uint32_t /* session_id */)	327 uint32_t /* session_id */)

324	328

	329 IPC_MESSAGE_ROUTED3(MediaKeysMsg_SessionApproved,
	ddorwin 2013/12/20 23:59:52 Can we think of a better name than SessionApproved Can we think of a better name than SessionApproved? SessionCreationAllowed? It's weird naming - the name is positive but a parameter can make the meaning negative. This is another reason why making this message the failure case (see later) is appealing. Kibeom Kim (inactive) 2013/12/30 12:33:05 Done. (Removed) Show quoted text On 2013/12/20 23:59:52, ddorwin wrote: > Can we think of a better name than SessionApproved? SessionCreationAllowed? > > It's weird naming - the name is positive but a parameter can make the meaning > negative. This is another reason why making this message the failure case (see > later) is appealing. Done. (Removed)
	330 int /* media_keys_id */,

	331 uint32_t /* session_id */,

	332 bool /* success */)

	333

325 IPC_MESSAGE_ROUTED4(MediaKeysMsg_SessionError,	334 IPC_MESSAGE_ROUTED4(MediaKeysMsg_SessionError,

326 int /* media_keys_id */,	335 int /* media_keys_id */,

327 uint32_t /* session_id */,	336 uint32_t /* session_id */,

328 media::MediaKeys::KeyError /* error_code */,	337 media::MediaKeys::KeyError /* error_code */,

329 int /* system_code */)	338 int /* system_code */)

OLD	NEW