Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 1074003002: Catch screenrecord errors to avoid CommandFailedError. BUG=474684 (Closed)

Created:
5 years, 8 months ago by raywilliams
Modified:
5 years, 8 months ago
Reviewers:
jbudorick
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Catch screenrecord errors to avoid CommandFailedError. BUG=474684 Committed: https://crrev.com/980327417d215625b8e7840752eb5f56aadcaed6 Cr-Commit-Position: refs/heads/master@{#324647}

Patch Set 1 #

Patch Set 2 : Added missing imports #

Total comments: 2

Patch Set 3 : Changed a character in the log output #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M build/android/pylib/screenshot.py View 1 2 2 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
jbudorick
lgtm w/ nit https://codereview.chromium.org/1074003002/diff/20001/build/android/pylib/screenshot.py File build/android/pylib/screenshot.py (right): https://codereview.chromium.org/1074003002/diff/20001/build/android/pylib/screenshot.py#newcode79 build/android/pylib/screenshot.py:79: logging.warning('Nothing to Kill: screenrecord was not ...
5 years, 8 months ago (2015-04-09 22:51:14 UTC) #2
raywilliams
https://codereview.chromium.org/1074003002/diff/20001/build/android/pylib/screenshot.py File build/android/pylib/screenshot.py (right): https://codereview.chromium.org/1074003002/diff/20001/build/android/pylib/screenshot.py#newcode79 build/android/pylib/screenshot.py:79: logging.warning('Nothing to Kill: screenrecord was not running') On 2015/04/09 ...
5 years, 8 months ago (2015-04-10 15:05:45 UTC) #3
raywilliams
5 years, 8 months ago (2015-04-10 15:06:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1074003002/40001
5 years, 8 months ago (2015-04-10 15:29:59 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 8 months ago (2015-04-10 16:53:06 UTC) #8
commit-bot: I haz the power
5 years, 8 months ago (2015-04-10 16:53:55 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/980327417d215625b8e7840752eb5f56aadcaed6
Cr-Commit-Position: refs/heads/master@{#324647}

Powered by Google App Engine
This is Rietveld 408576698