Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Unified Diff: pkg/compiler/lib/src/resolution/members.dart

Issue 1073983003: Make invalid to override method names for local nested functions (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tests/co19/co19-dart2js.status » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/resolution/members.dart
diff --git a/pkg/compiler/lib/src/resolution/members.dart b/pkg/compiler/lib/src/resolution/members.dart
index 08174ecb312956c878c7054954eb23381f83eed7..b9d2abda17880060291d3a1056589c1ec3bd85af 100644
--- a/pkg/compiler/lib/src/resolution/members.dart
+++ b/pkg/compiler/lib/src/resolution/members.dart
@@ -3011,19 +3011,17 @@ class ResolverVisitor extends MappingVisitor<ResolutionResult> {
setter = reportAndCreateErroneousElement(node.selector, target.name,
MessageKind.ASSIGNING_TYPE, const {});
registry.registerThrowNoSuchMethod();
- } else if (target.isFinal ||
- target.isConst ||
- (target.isFunction &&
- Elements.isStaticOrTopLevelFunction(target) &&
- !target.isSetter)) {
- if (target.isFunction) {
- setter = reportAndCreateErroneousElement(node.selector, target.name,
- MessageKind.ASSIGNING_METHOD, const {});
- } else {
- setter = reportAndCreateErroneousElement(node.selector, target.name,
- MessageKind.CANNOT_RESOLVE_SETTER, const {});
- }
+ } else if (target.isFinal || target.isConst) {
+ setter = reportAndCreateErroneousElement(
+ node.selector, target.name, MessageKind.CANNOT_RESOLVE_SETTER,
+ const {});
+ registry.registerThrowNoSuchMethod();
+ } else if (target.isFunction && target.name != '[]=') {
+ assert(!target.isSetter);
+ setter = reportAndCreateErroneousElement(
+ node.selector, target.name, MessageKind.ASSIGNING_METHOD, const {});
registry.registerThrowNoSuchMethod();
+ if (node.isSuperCall) registry.registerSuperNoSuchMethod();
}
if (isPotentiallyMutableTarget(target)) {
registry.registerPotentialMutation(target, node);
« no previous file with comments | « no previous file | tests/co19/co19-dart2js.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698