Make invalid to override method names for local nested functions

pkg/compiler/lib/src/resolution/members.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of resolution;
 
 abstract class TreeElements {
   AnalyzableElement get analyzedElement;
   Iterable<Node> get superUses;
 
@@ skipping 2976 matching lines @@
         }
         if (isComplex && getter == null && !inInstanceContext) {
           getter = warnAndCreateErroneousElement(
               node.selector, field.name, MessageKind.CANNOT_RESOLVE_GETTER);
           registry.registerThrowNoSuchMethod();
         }
       } else if (target.impliesType) {
         setter = warnAndCreateErroneousElement(
             node.selector, target.name, MessageKind.ASSIGNING_TYPE);
         registry.registerThrowNoSuchMethod();
-      } else if (target.isFinal ||
-                 target.isConst ||
-                 (target.isFunction &&
-                  Elements.isStaticOrTopLevelFunction(target) &&
-                  !target.isSetter)) {
-        if (target.isFunction) {
-          setter = warnAndCreateErroneousElement(
-              node.selector, target.name, MessageKind.ASSIGNING_METHOD);
-        } else {
-          setter = warnAndCreateErroneousElement(
+      } else if (target.isFinal || target.isConst) {
+        setter = warnAndCreateErroneousElement(
               node.selector, target.name, MessageKind.CANNOT_RESOLVE_SETTER);
-        }
         registry.registerThrowNoSuchMethod();
+      } else if (target.isFunction && target.name != '[]=') {
+        assert(!target.isSetter);

[Siggi Cherem (dart-lang), 2015/04/11 00:12:21]

in your original patch, you had this as part of the condition, but it seemed to
me like isFunction implies this, or am I missing something?

[Johnni Winther, 2015/04/13 09:41:09]

You're right - and I did document isFunction accordingly ;-)

+        setter = warnAndCreateErroneousElement(
+            node.selector, target.name, MessageKind.ASSIGNING_METHOD);
+        registry.registerThrowNoSuchMethod();
+        if (node.isSuperCall) registry.registerSuperNoSuchMethod();

[Siggi Cherem (dart-lang), 2015/04/11 00:12:21]

without this, codegen may fail later on (createInvocationMirror is not built at
the right time).

I noticed that in some places you also do
`registry.registerDynamicInvoke(selector);` as well (e.g. in resolveSend). Here
it seems to me we don't need to because we call registerSend at the end of this
method. Is my understanding correct?

[Johnni Winther, 2015/04/13 09:41:09]

Nice catch. And you're right about the selectors.

       }
       if (isPotentiallyMutableTarget(target)) {
         registry.registerPotentialMutation(target, node);
         if (enclosingElement != target.enclosingElement) {
           registry.registerPotentialMutationInClosure(target, node);
         }
         for (Node scope in promotionScope) {
           registry.registerPotentialMutationIn(scope, target, node);
         }
       }
@@ skipping 2076 matching lines @@
 }
 
 /// The result for the resolution of the `assert` method.
 class AssertResult implements ResolutionResult {
   const AssertResult();
 
   Element get element => null;
 
   String toString() => 'AssertResult()';
 }