Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 1073953006: New insertion write barrier. (Closed)

Created:
5 years, 8 months ago by Hannes Payer (out of office)
Modified:
5 years, 7 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

New insertion write barrier. BUG= Committed: https://crrev.com/6e9e2c08292b553602c74b16b8ccff4e4ccac003 Cr-Commit-Position: refs/heads/master@{#28199}

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -25 lines) Patch
M src/heap/incremental-marking-inl.h View 1 1 chunk +2 lines, -18 lines 0 comments Download
M src/heap/spaces.h View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 18 (11 generated)
Hannes Payer (out of office)
5 years, 7 months ago (2015-05-04 10:40:22 UTC) #10
ulan
lgtm https://codereview.chromium.org/1073953006/diff/180001/src/heap/spaces.h File src/heap/spaces.h (right): https://codereview.chromium.org/1073953006/diff/180001/src/heap/spaces.h#newcode495 src/heap/spaces.h:495: DCHECK(IsFlagSet(HAS_PROGRESS_BAR)); Can we remove the rest of "progress_bar" ...
5 years, 7 months ago (2015-05-04 10:43:49 UTC) #11
Hannes Payer (out of office)
https://codereview.chromium.org/1073953006/diff/180001/src/heap/spaces.h File src/heap/spaces.h (right): https://codereview.chromium.org/1073953006/diff/180001/src/heap/spaces.h#newcode495 src/heap/spaces.h:495: DCHECK(IsFlagSet(HAS_PROGRESS_BAR)); On 2015/05/04 10:43:49, ulan wrote: > Can we ...
5 years, 7 months ago (2015-05-04 12:43:14 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1073953006/200001
5 years, 7 months ago (2015-05-04 12:48:25 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:200001)
5 years, 7 months ago (2015-05-04 13:12:30 UTC) #16
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/6e9e2c08292b553602c74b16b8ccff4e4ccac003 Cr-Commit-Position: refs/heads/master@{#28199}
5 years, 7 months ago (2015-05-04 13:12:39 UTC) #17
Hannes Payer (out of office)
5 years, 7 months ago (2015-05-06 14:34:44 UTC) #18
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:200001) has been created in
https://codereview.chromium.org/1131583002/ by hpayer@chromium.org.

The reason for reverting is: Various performance regressions..

Powered by Google App Engine
This is Rietveld 408576698