Expose Object::DefineOwnProperty on the API

src/v8natives.js

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This file relies on the fact that the following declarations have been made
 // in runtime.js:
 // var $Object = global.Object;
 // var $Boolean = global.Boolean;
 // var $Number = global.Number;
 // var $Function = global.Function;
@@ skipping 696 matching lines @@
       throw MakeTypeError("handler_returned_false",
                           [handler, "defineProperty"]);
     } else {
       return false;
     }
   }
   return true;
 }
 
 
+function DefineObjectPropertyFromAPI(obj, p, value, configurable, enumerable,
+                                     writable) {
+  DefineObjectProperty(obj, p, ToPropertyDescriptor({

[adamk, 2015/04/15 16:31:53]

I think you're entering too late, and should call DefineOwnProperty().  Please
add a test where the API method is called on an Array with the property
"length", as I think bad things will happen (see DefineArrayProperty for what
sort of special handling we do).

+    value: value,
+    configurable: configurable,
+    enumerable: enumerable,
+    writable: writable
+  }),
+                       true);
+  return this;
+}
+
+
 // ES5 8.12.9.
 function DefineObjectProperty(obj, p, desc, should_throw) {
   var current_array = %GetOwnProperty(obj, ToName(p));
   var current = ConvertDescriptorArrayToDescriptor(current_array);
   var extensible = %IsExtensible(obj);
 
   // Error handling according to spec.
   // Step 3
   if (IS_UNDEFINED(current) && !extensible) {
     if (should_throw) {
@@ skipping 1187 matching lines @@
   }
   if (!IS_SPEC_FUNCTION(method)) {
     throw MakeTypeError('not_iterable', [obj]);
   }
   var iterator = %_CallFunction(obj, method);
   if (!IS_SPEC_OBJECT(iterator)) {
     throw MakeTypeError('not_an_iterator', [iterator]);
   }
   return iterator;
 }