Expose Object::DefineOwnProperty on the API

include/v8.h

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /** \mainpage V8 API Reference Guide
  *
  * V8 is Google's open source JavaScript engine.
  *
  * This set of documents provides reference material generated from the
  * V8 header file, include/v8.h.
@@ skipping 2668 matching lines @@
   // will only be returned if the interceptor doesn't return a value.
   //
   // Note also that this only works for named properties.
   V8_DEPRECATE_SOON("Use maybe version",
                     bool ForceSet(Handle<Value> key, Handle<Value> value,
                                   PropertyAttribute attribs = None));
   // TODO(dcarney): mark V8_WARN_UNUSED_RESULT
   Maybe<bool> ForceSet(Local<Context> context, Local<Value> key,
                        Local<Value> value, PropertyAttribute attribs = None);
 
+  V8_WARN_UNUSED_RESULT MaybeLocal<Value> DefineObjectProperty(

[adamk, 2015/04/15 16:31:53]

Why not "DefineOwnProperty"? Also, it seems like it might be more useful to make
this non-throwing (in normal operation) and return a boolean, with true meaning
success and false meaning failure. This would better match up with
[[DefineOwnProperty]], which is what I was thinking of when I filed this bug.
The callers of this in the embedder are more like "spec code" than user code,
and the boolean is going to be easier to handle than sprinkling TryCatches and
ASSERTs around.

[dcarney, 2015/04/15 19:02:56]

i think a  maybe<bool> is better than a meaningless maybelocal, but in either
case, the result is meaningless. only the presence of a result signals non
exceptional execution, whereas the absence signal something thrown.  what we
would really need here would be maybe<void>

+      Local<Context> context, Local<Value> key, Local<Value> value,

[adamk, 2015/04/15 16:31:53]

Why not add a version that takes a uint32_t key? That'd match up with Set/Get,
and make this more convenient to use with Arrays (which is one of the places
where ForceSet currently doesn't work well).

+      PropertyAttribute attribute = None);
+
   V8_DEPRECATE_SOON("Use maybe version", Local<Value> Get(Handle<Value> key));
   V8_WARN_UNUSED_RESULT MaybeLocal<Value> Get(Local<Context> context,
                                               Local<Value> key);
 
   V8_DEPRECATE_SOON("Use maybe version", Local<Value> Get(uint32_t index));
   V8_WARN_UNUSED_RESULT MaybeLocal<Value> Get(Local<Context> context,
                                               uint32_t index);
 
   /**
    * Gets the property attributes of a property which can be None or
@@ skipping 5393 matching lines @@
  */
 
 
 }  // namespace v8
 
 
 #undef TYPE_CHECK
 
 
 #endif  // V8_H_