Expose Object::DefineOwnProperty on the API

test/cctest/test-api.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 13379 matching lines @@
   CHECK_EQ(1, force_set_set_count);
   CHECK_EQ(5, force_set_get_count);
   // The interceptor should also work for other properties
   CHECK_EQ(3, global->Get(v8::String::NewFromUtf8(isolate, "b"))
                   ->Int32Value());
   CHECK_EQ(1, force_set_set_count);
   CHECK_EQ(6, force_set_get_count);
 }
 
 
+TEST(DefineObjectProperty) {
+  LocalContext env;
+  v8::Isolate* isolate = env->GetIsolate();
+  v8::HandleScope handle_scope(isolate);
+
+  CompileRun(
+      "var a = {};"
+      "Object.defineProperty(a, 'foo', {value: 23});");
+
+  v8::Local<v8::Object> obj =
+      v8::Local<v8::Object>::Cast(env->Global()->Get(v8_str("a")));
+
+  {
+    v8::TryCatch try_catch;
+    CHECK(obj->DefineObjectProperty(env.local(), v8_str("foo"),
+                                    v8::Integer::New(isolate, 42)).IsEmpty());
+    CHECK(try_catch.HasCaught());
+  }
+
+  {
+    v8::TryCatch try_catch;
+    obj->DefineObjectProperty(env.local(), v8_str("bar"),
+                              v8::Integer::New(isolate, 42)).ToLocalChecked();
+    CHECK(!try_catch.HasCaught());
+    v8::MaybeLocal<v8::Value> maybe_val = obj->Get(env.local(), v8_str("bar"));
+    v8::Local<v8::Value> val = maybe_val.ToLocalChecked();

[dcarney, 2015/04/15 08:31:17]

as a rule, always try to hide Maybes and MaybeLocals, just use ToLocalChecked
directly on the result

[jochen (gone - plz use gerrit), 2015/04/15 08:35:18]

done

+    CHECK(val->IsNumber());
+    v8::Maybe<double> num = val->NumberValue(env.local());
+    CHECK_EQ(42.0, num.FromJust());
+  }
+
+  {
+    v8::TryCatch try_catch;
+    obj->DefineObjectProperty(env.local(), v8_str("1"),
+                              v8::Integer::New(isolate, 23)).ToLocalChecked();
+    CHECK(!try_catch.HasCaught());
+    v8::MaybeLocal<v8::Value> maybe_val = obj->Get(env.local(), 1);
+    v8::Local<v8::Value> val = maybe_val.ToLocalChecked();
+    CHECK(val->IsNumber());
+    v8::Maybe<double> num = val->NumberValue(env.local());
+    CHECK_EQ(23.0, num.FromJust());
+  }
+
+  CompileRun("Object.freeze(a);");
+
+  {
+    v8::TryCatch try_catch;
+    CHECK(obj->DefineObjectProperty(env.local(), v8_str("baz"),
+                                    v8::Integer::New(isolate, 42)).IsEmpty());
+    CHECK(try_catch.HasCaught());
+  }
+}
+
+
 static v8::Local<Context> calling_context0;
 static v8::Local<Context> calling_context1;
 static v8::Local<Context> calling_context2;
 
 
 // Check that the call to the callback is initiated in
 // calling_context2, the directly calling context is calling_context1
 // and the callback itself is in calling_context0.
 static void GetCallingContextCallback(
     const v8::FunctionCallbackInfo<v8::Value>& args) {
@@ skipping 8501 matching lines @@
 
   {
     v8::HandleScope handle_scope(isolate);
 
     // Should work
     v8::Local<v8::Object> obj = v8::Object::New(isolate);
 
     USE(obj);
   }
 }