Issue 1073933002: XFA port: Include windows.h instead of the MFC header afxres.h

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1073933002: XFA port: Include windows.h instead of the MFC header afxres.h (Closed)

Created:
5 years, 8 months ago by brucedawson

Modified:
5 years, 8 months ago

Reviewers:
Tom Sepez

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa

Target Ref:
refs/heads/xfa

Visibility:
Public.

XFA port: Include windows.h instead of the MFC header afxres.h VS 2015 RC ships without afxres.h, so fpdfsdkdll.rc fails to compile. afxres.h is really intended for MFC apps so depending on it is a bad idea anyway, so I changed both references to windows.h. See http://stackoverflow.com/questions/1575559 for some other perspective on this. Ported from https://codereview.chromium.org/1078513002 TBR=tsepez@chromium.org BUG=440500 Committed: https://pdfium.googlesource.com/pdfium/+/24a9eb6acf48a10717f03fd8ec0ac8e3df41edfc

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -3 lines)			Patch
	M	.gitignore	View		2 chunks	+2 lines, -1 line	0 comments	Download
	M	fpdfsdk/src/fpdfsdkdll.rc	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Total messages: 2 (0 generated)

brucedawson

Committed patchset #1 (id:1) manually as 24a9eb6acf48a10717f03fd8ec0ac8e3df41edfc (presubmit successful).

5 years, 8 months ago (2015-04-09 20:52:10 UTC) #1

Message was sent while issue was closed.

lgtm