Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issue 1073893004: Fix blank video in Android WebView (Closed)

Created:
5 years, 8 months ago by boliu
Modified:
5 years, 8 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix blank video in Android WebView This bug is introduced in r324679. When Initialize/ReleaseHardware was removed, the call to the factory the kept a count on the number of compositors with hardware acceleration was dropped. This means the factory refuses to create a context for video. Add those callbacks, and emulate the original call by checking if the memory policy is zero. Committed: https://crrev.com/5ddc6ffcc0bda6d9a25613fb96adee249de135e7 Cr-Commit-Position: refs/heads/master@{#325345}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M content/browser/android/in_process/synchronous_compositor_impl.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M content/browser/android/in_process/synchronous_compositor_output_surface.h View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
boliu
ptal
5 years, 8 months ago (2015-04-15 22:57:21 UTC) #2
sgurun-gerrit only
lgtm
5 years, 8 months ago (2015-04-15 23:21:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1073893004/1
5 years, 8 months ago (2015-04-15 23:23:28 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-15 23:41:15 UTC) #7
commit-bot: I haz the power
5 years, 8 months ago (2015-04-15 23:42:10 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5ddc6ffcc0bda6d9a25613fb96adee249de135e7
Cr-Commit-Position: refs/heads/master@{#325345}

Powered by Google App Engine
This is Rietveld 408576698