Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 1073893002: PPC: JSEntryTrampoline: check for stack space before pushing arguments (Closed)

Created:
5 years, 8 months ago by michael_dawson
Modified:
5 years, 8 months ago
Reviewers:
MTBrandyberry
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: JSEntryTrampoline: check for stack space before pushing arguments Port 146598f44a1efd0f942745abfd6c08a073972c01 Original commit message: Optimistically pushing a lot of arguments can run into the stack limit of the process, at least on operating systems where this limit is close to the limit that V8 sets for itself. R=mbrandy@us.ibm.com BUG= Committed: https://crrev.com/a5d71c2cacfac17385e5baca833df3f8887283f7 Cr-Commit-Position: refs/heads/master@{#27719}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -26 lines) Patch
M src/ppc/builtins-ppc.cc View 5 chunks +47 lines, -26 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
michael_dawson
Catching up next ppc port
5 years, 8 months ago (2015-04-09 19:48:22 UTC) #1
MTBrandyberry
On 2015/04/09 19:48:22, michael_dawson wrote: > Catching up next ppc port lgtm
5 years, 8 months ago (2015-04-09 19:49:12 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1073893002/1
5 years, 8 months ago (2015-04-09 19:59:53 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-09 20:52:43 UTC) #5
commit-bot: I haz the power
5 years, 8 months ago (2015-04-09 20:52:57 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a5d71c2cacfac17385e5baca833df3f8887283f7
Cr-Commit-Position: refs/heads/master@{#27719}

Powered by Google App Engine
This is Rietveld 408576698