Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 1073883004: Make dump_dependency_json.py write <| list files to the output directory rather (Closed)

Created:
5 years, 8 months ago by lindleyf
Modified:
5 years, 7 months ago
CC:
gyp-developer_googlegroups.com, yukawa
Target Ref:
refs/heads/master
Project:
gyp
Visibility:
Public.

Description

Make dump_dependency_json.py write <| list files to the output directory rather than the source tree. Also write the dump.json output to the out directory. This is useful for two reasons. First, if you don't do this, then any <| files will show up as untracked files in your repo every time you run this, which is annoying. Second, if you're building in an environment where the source tree is read-only, gyp will crash when it tries to write those files and dump.json. BUG= R=thakis@chromium.org Committed: https://chromium.googlesource.com/external/gyp/+/3601f26003c6163128a66330ce845b5cb309c7a9

Patch Set 1 #

Patch Set 2 : Only relocate the dump.json file if output_dir is set. #

Total comments: 1

Patch Set 3 : Use os.path.join #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -1 line) Patch
M pylib/gyp/generator/dump_dependency_json.py View 1 2 2 chunks +16 lines, -1 line 0 comments Download

Messages

Total messages: 14 (4 generated)
yukawa
Nico, Scott, Evan, can you take a look at this CL? This CL was originally ...
5 years, 8 months ago (2015-04-22 01:14:48 UTC) #2
Nico
Generally this seems ok to me. Does this change the default output path? If so, ...
5 years, 8 months ago (2015-04-22 16:50:07 UTC) #3
lindleyf
On 2015/04/22 16:50:07, Nico (OOO sick) wrote: > Generally this seems ok to me. Does ...
5 years, 8 months ago (2015-04-22 18:16:28 UTC) #4
lindleyf
On 2015/04/22 18:16:28, lindleyf wrote: > On 2015/04/22 16:50:07, Nico (OOO sick) wrote: > > ...
5 years, 8 months ago (2015-04-22 18:27:41 UTC) #5
lindleyf
On 2015/04/22 18:27:41, lindleyf wrote: > On 2015/04/22 18:16:28, lindleyf wrote: > > On 2015/04/22 ...
5 years, 8 months ago (2015-04-22 19:39:27 UTC) #6
Nico
lgtm https://codereview.chromium.org/1073883004/diff/20001/pylib/gyp/generator/dump_dependency_json.py File pylib/gyp/generator/dump_dependency_json.py (right): https://codereview.chromium.org/1073883004/diff/20001/pylib/gyp/generator/dump_dependency_json.py#newcode92 pylib/gyp/generator/dump_dependency_json.py:92: filename = filepath + '/dump.json' nit: os.path.join
5 years, 8 months ago (2015-04-27 19:27:11 UTC) #7
commit-bot: I haz the power
Commit queue rejected this change because it did not recognize the base URL. Please commit ...
5 years, 7 months ago (2015-04-28 22:32:24 UTC) #11
lindleyf
5 years, 7 months ago (2015-04-28 22:33:25 UTC) #12
Nico
Committed patchset #3 (id:40001) manually as 3601f26003c6163128a66330ce845b5cb309c7a9.
5 years, 7 months ago (2015-04-28 22:48:52 UTC) #13
Nico
5 years, 7 months ago (2015-04-28 22:49:18 UTC) #14

Powered by Google App Engine
This is Rietveld 408576698