Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Issue 1073883002: Change logging to syslog; fix CRD in Yosemite (Closed)

Created:
5 years, 8 months ago by dcaiafa
Modified:
5 years, 8 months ago
Reviewers:
Jamie
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change logging to use syslog; fix CRD in Yosemite Have the Chromoting host write logs to syslog. This works around the issue where, in some Yosemite configurations, launchd fails to start the agent if the user running the agent does not have write access to the log or the log's directory. Logging to syslog has additional advantages such as: - Log rotation and overflow are now managed by the system. - Messages are read-restricted to the user running the agent. After this change, logs will no longer be stored in /var/log/org.chromium.chromoting.log. To obtain logs, use the following command: sudo syslog -k Facility org.chromium.chromoting If 'sudo' is omitted, messages logged in the login screen (while the agent is running as root) will not be available. N.B. The changes to ChromotingHostService.pkgproj were made using the 'Packages' program. To test the changes, I built and installed a .dmg from scratch. BUG=468121 Committed: https://crrev.com/25cef11863014bc8ff4a8ff16d8570ad9c62bedc Cr-Commit-Position: refs/heads/master@{#324550}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -93 lines) Patch
M remoting/host/installer/mac/ChromotingHostService.pkgproj View 1 chunk +0 lines, -50 lines 0 comments Download
D remoting/host/installer/mac/Config/org.chromium.chromoting.conf View 1 chunk +0 lines, -11 lines 0 comments Download
M remoting/host/installer/mac/LaunchAgents/org.chromium.chromoting.plist View 1 chunk +0 lines, -4 lines 0 comments Download
M remoting/host/installer/mac/Scripts/remoting_postflight.sh View 2 chunks +0 lines, -9 lines 0 comments Download
A + remoting/host/logging_linux.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A remoting/host/logging_mac.cc View 1 chunk +101 lines, -0 lines 0 comments Download
D remoting/host/logging_posix.cc View 1 chunk +0 lines, -18 lines 0 comments Download
M remoting/remoting_host_mac.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M remoting/remoting_host_srcs.gypi View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
dcaiafa
ptal
5 years, 8 months ago (2015-04-09 19:47:00 UTC) #2
Jamie
lgtm
5 years, 8 months ago (2015-04-09 23:12:04 UTC) #3
Jamie
Please update the wiki instructions on log gathering to include information on how to use ...
5 years, 8 months ago (2015-04-09 23:13:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1073883002/1
5 years, 8 months ago (2015-04-09 23:49:00 UTC) #6
dcaiafa
On 2015/04/09 23:13:11, Jamie wrote: > Please update the wiki instructions on log gathering to ...
5 years, 8 months ago (2015-04-10 00:11:03 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-10 01:07:16 UTC) #8
commit-bot: I haz the power
5 years, 8 months ago (2015-04-10 01:08:54 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/25cef11863014bc8ff4a8ff16d8570ad9c62bedc
Cr-Commit-Position: refs/heads/master@{#324550}

Powered by Google App Engine
This is Rietveld 408576698