Upstream string_util function.

Upstream string_util function.

Create ios/chrome/common as these functions may be needed by external components.

Narrowing DEPS from ios/chrome to ios/chrome/browser.

TBR=mef, sdefresne,rsesek, thakis

Committed: https://crrev.com/09508e0b6219f0febf9a609e1c9ff6d6eb6dde8e
Cr-Commit-Position: refs/heads/master@{#324860}

Committed: https://crrev.com/b3e6bc4f2603cb4087b0dff910e92b7c06487be7
Cr-Commit-Position: refs/heads/master@{#325013}

[Olivier, 2015-04-10 15:55:39]

The CQ bit was checked by olivierrobin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-04-10 15:56:26]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1073863005/20001

[commit-bot: I haz the power, 2015-04-10 15:56:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-10 15:56:28]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[Olivier, 2015-04-13 07:38:00]

olivierrobin@chromium.org changed reviewers:
+ droger@chromium.org, sdefresne@chromium.org

[droger, 2015-04-13 09:49:13]

Please add a README.txt file in ios/chrome/common with a content like:
This directory holds code shared by Chrome and Chrome iOS extensions.

As per offline discussion:
- please move most of DEPS in ios/chrome to ios/chrome/browser, so that you
don't share these DEPS
- please cherry pick your change asap, so that we don't end up with two versions
of the file downstream.

https://codereview.chromium.org/1073863005/diff/40001/ios/chrome/ios_chrome.gyp
File ios/chrome/ios_chrome.gyp (right):

https://codereview.chromium.org/1073863005/diff/40001/ios/chrome/ios_chrome.g...
ios/chrome/ios_chrome.gyp:213:
'$(SDKROOT)/System/Library/Frameworks/Foundation.framework',
Looks like we also need:
'$(SDKROOT)/System/Library/Frameworks/CoreGraphics.framework',

https://codereview.chromium.org/1073863005/diff/40001/ios/chrome/ios_chrome_t...
File ios/chrome/ios_chrome_tests.gyp (right):

https://codereview.chromium.org/1073863005/diff/40001/ios/chrome/ios_chrome_t...
ios/chrome/ios_chrome_tests.gyp:22: 'ios_chrome.gyp:ios_chrome_browser',
Add ios_chrome.gyp:ios_chrome_common here too.

[Olivier, 2015-04-13 15:58:57]

olivierrobin@chromium.org changed reviewers:
+ mef@chromium.org, rsesek@chromium.org, thakis@chromium.org

[Olivier, 2015-04-13 16:02:05]

Hi,

This CL makes the DEPS stricter by moving DEPS file from ios/chrome to
ios/chrome/browser.

TBR ios/chrome/browser/DEPS:
thakis for DEPS on ui and skia
rsesek for google_toolbox_for_mac
mef for net
sdefresne for components

https://codereview.chromium.org/1073863005/diff/40001/ios/chrome/ios_chrome.gyp
File ios/chrome/ios_chrome.gyp (right):

https://codereview.chromium.org/1073863005/diff/40001/ios/chrome/ios_chrome.g...
ios/chrome/ios_chrome.gyp:213:
'$(SDKROOT)/System/Library/Frameworks/Foundation.framework',
On 2015/04/13 09:49:13, droger wrote:
> Looks like we also need:
> '$(SDKROOT)/System/Library/Frameworks/CoreGraphics.framework',

Done.

https://codereview.chromium.org/1073863005/diff/40001/ios/chrome/ios_chrome_t...
File ios/chrome/ios_chrome_tests.gyp (right):

https://codereview.chromium.org/1073863005/diff/40001/ios/chrome/ios_chrome_t...
ios/chrome/ios_chrome_tests.gyp:22: 'ios_chrome.gyp:ios_chrome_browser',
On 2015/04/13 09:49:13, droger wrote:
> Add ios_chrome.gyp:ios_chrome_common here too.

Done.

[Olivier, 2015-04-13 16:02:10]

The CQ bit was checked by olivierrobin@chromium.org

[commit-bot: I haz the power, 2015-04-13 16:03:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1073863005/60001

[commit-bot: I haz the power, 2015-04-13 16:03:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-13 16:03:26]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[mef, 2015-04-13 16:06:42]

net to DEPS lgtm

[droger, 2015-04-13 16:09:06]

lgtm

[Olivier, 2015-04-13 16:09:40]

The CQ bit was checked by olivierrobin@chromium.org

[commit-bot: I haz the power, 2015-04-13 16:11:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1073863005/60001

[commit-bot: I haz the power, 2015-04-13 16:50:37]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-04-13 16:51:33]

Patchset 4 (id:??) landed as
https://crrev.com/09508e0b6219f0febf9a609e1c9ff6d6eb6dde8e
Cr-Commit-Position: refs/heads/master@{#324860}

[Mark P, 2015-04-13 17:39:09]

A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/1066013003/ by mpearson@chromium.org.

The reason for reverting is: Causes checkdeps failures:
https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests/builds/232...

ERROR in
/mnt/data/b/build/slave/Linux_Tests/build/src/ios/chrome/test/ios_chrome_unit_test_suite.cc
  Illegal include: "ios/public/test/test_chrome_browser_provider.h"
    Because of "-ios" from ios's include_rules.
  Illegal include: "ios/public/test/test_chrome_provider_initializer.h"
    Because of "-ios" from ios's include_rules.
  Illegal include: "ios/web/public/web_client.h"
    Because of "-ios" from ios's include_rules.
  Illegal include: "ui/base/ui_base_paths.h"
    Because of no rule applying.

ERROR in
/mnt/data/b/build/slave/Linux_Tests/build/src/ios/chrome/test/testing_application_context.cc
  Illegal include:
"ios/public/provider/chrome/browser/chrome_browser_provider.h"
    Because of "-ios" from ios's include_rules.

FAILED
.

[Olivier, 2015-04-14 07:45:43]

The CQ bit was checked by olivierrobin@chromium.org

[Olivier, 2015-04-14 07:45:43]

The patchset sent to the CQ was uploaded after l-g-t-m from droger@chromium.org,
mef@chromium.org
Link to the patchset: https://codereview.chromium.org/1073863005/#ps80001
(title: "test deps")

[commit-bot: I haz the power, 2015-04-14 07:45:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1073863005/80001

[commit-bot: I haz the power, 2015-04-14 08:11:45]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-04-14 08:12:41]

Patchset 5 (id:??) landed as
https://crrev.com/b3e6bc4f2603cb4087b0dff910e92b7c06487be7
Cr-Commit-Position: refs/heads/master@{#325013}