Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 1073843002: [Telemetry] Change BeginInteraction -> CreateInteraction for polymer page. (Closed)

Created:
5 years, 8 months ago by nednguyen
Modified:
5 years, 8 months ago
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Telemetry] Change BeginInteraction -> CreateInteraction for polymer page. BUG=475090 Committed: https://crrev.com/9e1bf62a4f3280db788e26364411ba1ff9728ab3 Cr-Commit-Position: refs/heads/master@{#324530}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -52 lines) Patch
M tools/perf/page_sets/polymer.py View 4 chunks +42 lines, -52 lines 0 comments Download

Messages

Total messages: 15 (5 generated)
nednguyen
Tryjob link: https://codereview.chromium.org/1072113002
5 years, 8 months ago (2015-04-09 17:12:58 UTC) #2
nednguyen
On 2015/04/09 17:12:58, nednguyen wrote: > Tryjob link: https://codereview.chromium.org/1072113002 The tryjob pass on nexus 4, ...
5 years, 8 months ago (2015-04-09 20:28:06 UTC) #3
eakuefner
lgtm but you know my opinion doesn't count for another 24-48 hours :) also, you ...
5 years, 8 months ago (2015-04-09 21:12:05 UTC) #4
eakuefner
On 2015/04/09 21:12:05, eakuefner wrote: > lgtm but you know my opinion doesn't count for ...
5 years, 8 months ago (2015-04-09 21:13:02 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1073843002/1
5 years, 8 months ago (2015-04-09 21:33:55 UTC) #7
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 8 months ago (2015-04-09 21:33:58 UTC) #9
dtu
lgtm
5 years, 8 months ago (2015-04-09 21:52:47 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1073843002/1
5 years, 8 months ago (2015-04-09 21:53:44 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-09 22:56:01 UTC) #14
commit-bot: I haz the power
5 years, 8 months ago (2015-04-09 22:56:51 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9e1bf62a4f3280db788e26364411ba1ff9728ab3
Cr-Commit-Position: refs/heads/master@{#324530}

Powered by Google App Engine
This is Rietveld 408576698