Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Side by Side Diff: LayoutTests/fast/dom/Attr/update-attribute-node-null-value-no-crash.html

Issue 1073823002: Correctly handle updates over attached Attrs involving null values. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | LayoutTests/fast/dom/Attr/update-attribute-node-null-value-no-crash-expected.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
(Empty)
1 <!DOCTYPE HTML>
2 <html>
3 <head>
4 <script src="../../../resources/js-test.js"></script>
5 </head>
6 <body>
7 <script>
8 description("Updating value of an attached Attr node having a null value");
9
10 var element = document.createElement("div");
11 var attr = document.createAttribute("nullable");
12 shouldBeEmptyString("attr.value");
13 shouldBeNull("attr.value = null; attr.value");
14 shouldBeNull("element.setAttributeNode(attr);");
15 shouldBeNull("element.getAttribute('nullable');");
16 shouldBeEqualToString("attr.value = 'noCrash'; attr.value", "noCrash");
17 shouldBeEqualToString("element.getAttribute('nullable')", "noCrash");
18 shouldBeNull("attr.value = null; attr.value");
19 shouldBeNull("element.getAttribute('nullable')");
20 </script>
21 </body>
22 </html>
OLDNEW
« no previous file with comments | « no previous file | LayoutTests/fast/dom/Attr/update-attribute-node-null-value-no-crash-expected.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698