Source/core/svg/SVGLengthContext.h - Issue 1073803002: SVG doesn't recognize ch units.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/svg/SVGLengthContext.h

Issue 1073803002: SVG doesn't recognize ch units. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Changed font-familt from serif to Ahem and align with review comments Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/svg/SVGLengthContext.h

diff --git a/Source/core/svg/SVGLengthContext.h b/Source/core/svg/SVGLengthContext.h

index 3e2ba449e39ff51955464b4e114178830188c6b6..7ac95c59ae1a36ae08b96b0766ae75dcb8b0e98d 100644

--- a/Source/core/svg/SVGLengthContext.h

+++ b/Source/core/svg/SVGLengthContext.h

@@ -43,7 +43,8 @@ enum SVGLengthType {

LengthTypeIN,

LengthTypePT,

LengthTypePC,

- LengthTypeREMS

+ LengthTypeREMS,

+ LengthTypeCHS

};

enum class SVGLengthMode {

@@ -89,6 +90,9 @@ private:

float convertValueFromUserUnitsToREMS(float value) const;

float convertValueFromREMSToUserUnits(float value) const;

+ float convertValueFromUserUnitsToCHS(float value) const;

+ float convertValueFromCHSToUserUnits(float value) const;

RawPtrWillBeMember<const SVGElement> m_context;

};