LayoutTests/svg/repaint/svg-length-ch-unit-font-size-change.html - Issue 1073803002: SVG doesn't recognize ch units.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/svg/repaint/svg-length-ch-unit-font-size-change.html

Issue 1073803002: SVG doesn't recognize ch units. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/fast/svg/svglength.html ('k') | LayoutTests/svg/repaint/svg-length-ch-unit-font-size-change-expected.html » ('j') | Source/core/svg/SVGLengthContext.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE HTML>	1 <!DOCTYPE HTML>

2 <html style="font-size:10px">	2 <html style="font-size:10px">

3 <script src="../../fast/repaint/resources/text-based-repaint.js"></script>	3 <script src="../../fast/repaint/resources/text-based-repaint.js"></script>

4 <script>	4 <script>

5 window.testIsAsync = true;	5 window.testIsAsync = true;

6 window.onload = runRepaintAndPixelTest;	6 window.onload = runRepaintAndPixelTest;

7	7

8 function repaintTest() {	8 function repaintTest() {

9 setTimeout(function() {	9 setTimeout(function() {

10 document.getElementsByTagName("html")[0].style.fontSize="5px";	10 document.getElementById("rootdiv").style.fontSize="20px";

11 requestAnimationFrame(function() {	11 requestAnimationFrame(function() {

12 if (window.testRunner)	12 if (window.testRunner)

13 finishRepaintTest();	13 finishRepaintTest();

14 });	14 });

15 }, 0);	15 }, 0);

16 };	16 };

17 </script>	17 </script>

18 <body>	18 <body>

19 <div style="font-size:10px">	19 <div id="rootdiv" style="font-size:10px; font-family:serif">
	Erik Dahlström (inactive) 2015/04/10 08:43:18 It would be better to use a particular font instea It would be better to use a particular font instead of a generic family. The Ahem font is typically a good fit for these kind of things. This comment applies to all the tests using the 'ch' unit. Shanmuga Pandi 2015/04/10 11:46:15 Done. Show quoted text On 2015/04/10 08:43:18, Erik Dahlström wrote: > It would be better to use a particular font instead of a generic family. The > Ahem font is typically a good fit for these kind of things. This comment applies > to all the tests using the 'ch' unit. Done.
20 <svg style="width:20rem; height:20rem;">	20 <svg style="width:20ch; height:20ch;">

21 <rect width="20rem" height="20em" style="fill:rgb(0,0,255);" />	21 <rect width="20ch" height="20ch" style="fill:rgb(0,0,255);" />

22 </svg>	22 </svg>

23 </div>	23 </div>

24 </body>	24 </body>

25 </html>	25 </html>

OLD	NEW