Issue 1073783002: Turned m_sourceSize in preloadScanner to a float.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1073783002: Turned m_sourceSize in preloadScanner to a float. (Closed)

Created:
5 years, 8 months ago by Yoav Weiss

Modified:
5 years, 8 months ago

Reviewers:
Mike West

CC:
blink-reviews, blink-reviews-html_chromium.org, dglazkov+blink, Yoav Weiss

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Turned m_sourceSize in preloadScanner to a float. During my work on Client-Hints, I realized that m_sourceSize in the preloadScanner is an unsigned, rather than a float as it should be. This CL fixes that. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=193460

Patch Set 1 #

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+12 lines, -4 lines)			Patch
M	LayoutTests/http/tests/loading/preload-image-sizes-2x.html	View	2 chunks	+6 lines, -1 line	0 comments	Download
M	LayoutTests/http/tests/loading/preload-image-sizes-2x-expected.txt	View	1 chunk	+5 lines, -2 lines	0 comments	Download
M	Source/core/html/parser/HTMLPreloadScanner.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Yoav Weiss

Well, turns out sourceSize should be a float, but wasn't in the preloadScanner. Changed it ...

5 years, 8 months ago (2015-04-09 12:36:07 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1073783002/1

5 years, 8 months ago (2015-04-09 14:41:13 UTC) #5

commit-bot: I haz the power

5 years, 8 months ago (2015-04-09 17:51:50 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=193460

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages