remove SK_SUPPORT_LEGACY_PIXELREF_CONSTRUCTOR and make fInfo const

remove  SK_SUPPORT_LEGACY_PIXELREF_CONSTRUCTOR and make fInfo const

BUG=
R=halcanary@google.com

Committed: https://code.google.com/p/skia/source/detail?r=12863

[hal.canary, 2014-01-02 17:39:30]

LGTM, if it doesn't break Chrome too badly.

https://codereview.chromium.org/107373004/diff/1/src/core/SkPixelRef.cpp
File src/core/SkPixelRef.cpp (right):

https://codereview.chromium.org/107373004/diff/1/src/core/SkPixelRef.cpp#newc...
src/core/SkPixelRef.cpp:85: SkPixelRef::SkPixelRef(const SkImageInfo& info,
SkBaseMutex* mutex) : fInfo(info) {
Bikeshed: I prefer this syntax:

SkPixelRef::SkPixelRef(const SkImageInfo& info, SkBaseMutex* mutex)
    : fInfo(info)
    , fPixels(NULL)
    , fColorTable(NULL)  // we do not track ownership of this
    , fLockCount(0)
    , fIsImmutable(false)
    , fPreLocked(false) {
    this->setMutex(mutex);
    this->needsNewGenID();
}

[reed1, 2014-01-02 18:07:50]

Committed patchset #1 manually as r12863 (presubmit successful).