[Ozone] VAAPI wrapper should open its own render node.

[Ozone] VAAPI wrapper should open its own render node.

This prevents a double-close problem that arises when libva uses the same drm
fd as gbm.

TODO(hshi): refactor VAAPI wrapper's management of drm file (crbug.com/475250).

BUG=462459
BUG=464628
TEST=verify that video acceleration works and the netflix hang is fixed
R=jorgelo@chromium.org, piman@chromium.org

Committed: https://chromium.googlesource.com/chromium/src/+/b46fe98550d339b8a5e2a56ce77d712499537539

[hshi1, 2015-04-08 21:55:17]

hshi@chromium.org changed reviewers:
+ alexst@chromium.org, ihf@chromium.org, jln@chromium.org, marcheu@chromium.org,
piman@chromium.org

[hshi1, 2015-04-08 21:55:18]

PTAL.

piman (OWNER contents)
jln (OWNER sandbox_linux)
ihf, marcheu, alexst (FYI)

[hshi1, 2015-04-08 21:59:09]

hshi@chromium.org changed reviewers:
+ jorgelo@chromium.org

[hshi1, 2015-04-08 21:59:09]

+jorgelo also, for the sandbox change

[piman, 2015-04-08 22:01:31]

LGTM. Can you file a bug to refactor this:
1- make sure we use the same file in all instances of VaapiWrapper
2- open the device node before the sandbox (e.g. pipe a PreSandboxInitialziation
to vdas)

[Jorge Lucangeli Obes, 2015-04-08 22:02:33]

On 2015/04/08 22:01:31, piman (Very slow to review) wrote:
> LGTM. Can you file a bug to refactor this:
> 1- make sure we use the same file in all instances of VaapiWrapper
> 2- open the device node before the sandbox (e.g. pipe a
PreSandboxInitialziation
> to vdas)

sandbox_linux LGTM

[hshi1, 2015-04-08 22:08:18]

The CQ bit was checked by hshi@chromium.org

[commit-bot: I haz the power, 2015-04-08 22:09:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1073653003/1

[Pawel Osciak, 2015-04-08 23:39:20]

posciak@chromium.org changed reviewers:
+ posciak@chromium.org

[Pawel Osciak, 2015-04-08 23:39:20]

https://codereview.chromium.org/1073653003/diff/1/content/common/gpu/media/va...
File content/common/gpu/media/vaapi_wrapper.cc (right):

https://codereview.chromium.org/1073653003/diff/1/content/common/gpu/media/va...
content/common/gpu/media/vaapi_wrapper.cc:294: const char* kDriRenderNode0Path =
"/dev/dri/renderD128";
I don't see this node on BYT or HSW for example...

Also, const base::FilePath::CharType* foo = FILE_PATH_LITERAL("foobar"); ?

[commit-bot: I haz the power, 2015-04-09 01:14:02]

Patchset 1 (id:??) landed as
https://crrev.com/b46fe98550d339b8a5e2a56ce77d712499537539
Cr-Commit-Position: refs/heads/master@{#324329}

[hshi1, 2015-04-09 01:14:18]

Committed patchset #1 (id:1) manually as
b46fe98550d339b8a5e2a56ce77d712499537539 (presubmit successful).