chrome/browser/safe_browsing/safe_browsing_service_browsertest.cc - Issue 1073633002: Remove PrerenderLocalPredictor, part 2.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/safe_browsing_service_browsertest.cc

Issue 1073633002: Remove PrerenderLocalPredictor, part 2. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@prerender-local-predictor-1

Patch Set: fix tests Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/safe_browsing/safe_browsing_database_unittest.cc ('K') | « chrome/browser/safe_browsing/safe_browsing_database_unittest.cc ('k') | chrome/browser/safe_browsing/safe_browsing_test.cc » ('j') | tools/metrics/histograms/histograms.xml » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/safe_browsing_service_browsertest.cc

diff --git a/chrome/browser/safe_browsing/safe_browsing_service_browsertest.cc b/chrome/browser/safe_browsing/safe_browsing_service_browsertest.cc

index 8923d648b91923b756b47593eb533d45c397f06b..249de9be96fbcaf7f119d2513093ed6f44ca2e72 100644

--- a/chrome/browser/safe_browsing/safe_browsing_service_browsertest.cc

+++ b/chrome/browser/safe_browsing/safe_browsing_service_browsertest.cc

@@ -168,9 +168,6 @@ class TestSafeBrowsingDatabase : public SafeBrowsingDatabase {

std::vector<SBPrefix>* prefix_hits) override {

return false;

}

- bool ContainsSideEffectFreeWhitelistUrl(const GURL& url) override {

- return true;

- }

bool ContainsMalwareIP(const std::string& ip_address) override {

return true;

}

@@ -277,7 +274,6 @@ class TestSafeBrowsingDatabaseFactory : public SafeBrowsingDatabaseFactory {

bool enable_client_side_whitelist,

bool enable_download_whitelist,

bool enable_extension_blacklist,

- bool enable_side_effect_free_whitelist,

bool enable_ip_blacklist,

bool enabled_unwanted_software_list) override {

db_ = new TestSafeBrowsingDatabase();