Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3254)

Unified Diff: chrome/browser/safe_browsing/safe_browsing_database_unittest.cc

Issue 1073633002: Remove PrerenderLocalPredictor, part 2. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@prerender-local-predictor-1
Patch Set: rebase Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/safe_browsing/safe_browsing_database_unittest.cc
diff --git a/chrome/browser/safe_browsing/safe_browsing_database_unittest.cc b/chrome/browser/safe_browsing/safe_browsing_database_unittest.cc
index 79c55865d727d08884dc9581c4f1cd86cc14d099..cfd7d95d6b0572792c45e37df289ca31870e83ed 100644
--- a/chrome/browser/safe_browsing/safe_browsing_database_unittest.cc
+++ b/chrome/browser/safe_browsing/safe_browsing_database_unittest.cc
@@ -286,8 +286,6 @@ class SafeBrowsingDatabaseTest : public PlatformTest {
new SafeBrowsingStoreFile(task_runner_);
SafeBrowsingStoreFile* extension_blacklist_store =
new SafeBrowsingStoreFile(task_runner_);
- SafeBrowsingStoreFile* side_effect_free_whitelist_store =
- new SafeBrowsingStoreFile(task_runner_);
SafeBrowsingStoreFile* ip_blacklist_store =
new SafeBrowsingStoreFile(task_runner_);
SafeBrowsingStoreFile* unwanted_software_store =
@@ -295,8 +293,8 @@ class SafeBrowsingDatabaseTest : public PlatformTest {
database_.reset(new SafeBrowsingDatabaseNew(
task_runner_, browse_store, download_store, csd_whitelist_store,
download_whitelist_store, inclusion_whitelist_store,
- extension_blacklist_store, side_effect_free_whitelist_store,
- ip_blacklist_store, unwanted_software_store));
+ extension_blacklist_store, ip_blacklist_store,
+ unwanted_software_store));
database_->Init(database_filename_);
}
@@ -445,11 +443,6 @@ TEST_F(SafeBrowsingDatabaseTest, ListNames) {
chunks.get());
chunks.clear();
- chunks.push_back(AddChunkFullHashValue(9, "www.sideeffectfree.com"));
- database_->InsertChunks(safe_browsing_util::kSideEffectFreeWhitelist,
- chunks.get());
-
- chunks.clear();
chunks.push_back(AddChunkHashedIpValue(10, "::ffff:192.168.1.0", 120));
database_->InsertChunks(safe_browsing_util::kIPBlacklist, chunks.get());
@@ -460,7 +453,7 @@ TEST_F(SafeBrowsingDatabaseTest, ListNames) {
database_->UpdateFinished(true);
GetListsInfo(&lists);
- ASSERT_EQ(10U, lists.size());
+ ASSERT_EQ(9U, lists.size());
EXPECT_EQ(safe_browsing_util::kMalwareList, lists[0].name);
EXPECT_EQ("1", lists[0].adds);
EXPECT_TRUE(lists[0].subs.empty());
@@ -482,15 +475,12 @@ TEST_F(SafeBrowsingDatabaseTest, ListNames) {
EXPECT_EQ(safe_browsing_util::kExtensionBlacklist, lists[6].name);
EXPECT_EQ("8", lists[6].adds);
EXPECT_TRUE(lists[6].subs.empty());
- EXPECT_EQ(safe_browsing_util::kSideEffectFreeWhitelist, lists[7].name);
- EXPECT_EQ("9", lists[7].adds);
+ EXPECT_EQ(safe_browsing_util::kIPBlacklist, lists[7].name);
+ EXPECT_EQ("10", lists[7].adds);
EXPECT_TRUE(lists[7].subs.empty());
- EXPECT_EQ(safe_browsing_util::kIPBlacklist, lists[8].name);
- EXPECT_EQ("10", lists[8].adds);
+ EXPECT_EQ(safe_browsing_util::kUnwantedUrlList, lists[8].name);
+ EXPECT_EQ("11", lists[8].adds);
EXPECT_TRUE(lists[8].subs.empty());
- EXPECT_EQ(safe_browsing_util::kUnwantedUrlList, lists[9].name);
- EXPECT_EQ("11", lists[9].adds);
- EXPECT_TRUE(lists[9].subs.empty());
database_.reset();
}
@@ -511,7 +501,7 @@ TEST_F(SafeBrowsingDatabaseTest, BrowseAndUnwantedDatabasesAndPrefixSets) {
&SafeBrowsingDatabase::ContainsBrowseUrl },
{ safe_browsing_util::kPhishingList, 1U,
&SafeBrowsingDatabase::ContainsBrowseUrl },
- { safe_browsing_util::kUnwantedUrlList, 9U,
+ { safe_browsing_util::kUnwantedUrlList, 8U,
&SafeBrowsingDatabase::ContainsUnwantedSoftwareUrl },
};
@@ -1125,7 +1115,7 @@ TEST_F(SafeBrowsingDatabaseTest, DISABLED_FileCorruptionHandling) {
base::MessageLoop loop;
SafeBrowsingStoreFile* store = new SafeBrowsingStoreFile(task_runner_);
database_.reset(new SafeBrowsingDatabaseNew(
- task_runner_, store, NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL));
+ task_runner_, store, NULL, NULL, NULL, NULL, NULL, NULL, NULL));
database_->Init(database_filename_);
// This will cause an empty database to be created.
@@ -1300,7 +1290,7 @@ TEST_F(SafeBrowsingDatabaseTest, Whitelists) {
// If the whitelist is disabled everything should match the whitelist.
database_.reset(new SafeBrowsingDatabaseNew(
task_runner_, new SafeBrowsingStoreFile(task_runner_), NULL, NULL, NULL,
- NULL, NULL, NULL, NULL, NULL));
+ NULL, NULL, NULL, NULL));
database_->Init(database_filename_);
for (const auto& test_case : kTestCases) {
SCOPED_TRACE(std::string("Tested list at fault => ") +

Powered by Google App Engine
This is Rietveld 408576698