Issue 107363004: ui/views: Remove gmock dependency from views_unittests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 107363004: ui/views: Remove gmock dependency from views_unittests. (Closed)

Created:
7 years ago by tfarina

Modified:
7 years ago

Reviewers:
sadrul, Ben Goodger (Google)

CC:
chromium-reviews, tfarina

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

ui/views: Remove gmock dependency from views_unittests. gmock is banned, so we rewrite the tests without relying in the black magic of gmock. BUG=134675 TEST=views_unittests --gtest_filter=ViewTest.*,SingleSplitViewTest.* R=ben@chromium.org,sadrul@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=241573

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+27 lines, -21 lines)			Patch
M	ui/views/DEPS	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	ui/views/controls/single_split_view_unittest.cc	View	9 chunks	+25 lines, -17 lines	0 comments	Download
M	ui/views/view_unittest.cc	View	2 chunks	+0 lines, -3 lines	0 comments	Download
M	ui/views/views.gyp	View	1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 5 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/107363004/1

7 years ago (2013-12-18 12:49:43 UTC) #4

Message was sent while issue was closed.

Change committed as 241573