Issue 107363002: Support custom serial bitrates on OS X

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 107363002: Support custom serial bitrates on OS X (Closed)

Created:
7 years ago by Ken Rockot(use gerrit already)

Modified:
7 years ago

Reviewers:
Bei Zhang

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Support custom serial bitrates on OS X BUG=243097 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=239235

Patch Set 1 #

Created: 7 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -0 lines)			Patch
	M	chrome/browser/extensions/api/serial/serial_connection_posix.cc	View		2 chunks	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Bei Zhang

On 2013/12/05 22:46:01, Ken Rockot wrote: > Please take a look! LGTM.

7 years ago (2013-12-05 23:09:11 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rockot@chromium.org/107363002/1

7 years ago (2013-12-05 23:24:47 UTC) #3

commit-bot: I haz the power

Retried try job too often on linux_rel for step(s) base_unittests, browser_tests, interactive_ui_tests, net_unittests, unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=199499

7 years ago (2013-12-06 07:47:25 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rockot@chromium.org/107363002/1

7 years ago (2013-12-06 15:55:02 UTC) #5

Message was sent while issue was closed.

Change committed as 239235

Expand Messages | Collapse Messages