Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 1073583004: Reverts Chromecast using external V8 snapshot files. (Closed)

Created:
5 years, 8 months ago by gunsch
Modified:
5 years, 8 months ago
CC:
chromium-reviews, gunsch+watch_chromium.org, lcwu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reverts Chromecast using external V8 snapshot files. This currently breaks at runtime both cast_shell and cast_shell_apk and I wasn't able to find an easy fix. I'd like to unblock our other development in the meantime. Half-revert of https://codereview.chromium.org/1019123002/ TBR=jochen@chromium.org R=rmcilroy@chromium.org,lcwu@chromium.org BUG=421063 Committed: https://crrev.com/99ed2aab6069a776024521b1242d6f519feb9948 Cr-Commit-Position: refs/heads/master@{#324376}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -5 lines) Patch
M build/common.gypi View 1 chunk +2 lines, -2 lines 0 comments Download
M chromecast/chromecast.gyp View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
gunsch
5 years, 8 months ago (2015-04-09 01:39:57 UTC) #1
lcwu1
lgtm
5 years, 8 months ago (2015-04-09 01:50:23 UTC) #3
gunsch
TBR'ing jochen@ on the revert to unblock. It's essentially a revert of https://codereview.chromium.org/1019123002/, but only ...
5 years, 8 months ago (2015-04-09 02:14:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1073583004/1
5 years, 8 months ago (2015-04-09 02:15:07 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-09 04:50:05 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/99ed2aab6069a776024521b1242d6f519feb9948 Cr-Commit-Position: refs/heads/master@{#324376}
5 years, 8 months ago (2015-04-09 04:50:55 UTC) #8
rmcilroy
5 years, 8 months ago (2015-04-09 09:35:51 UTC) #9
Message was sent while issue was closed.
On 2015/04/09 04:50:55, I haz the power (commit-bot) wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/99ed2aab6069a776024521b1242d6f519feb9948
> Cr-Commit-Position: refs/heads/master@{#324376}

lgtm (thanks for reverting only chromecast). I'll take a look at what's going
wrong before trying to reland.

Powered by Google App Engine
This is Rietveld 408576698