| Index: ui/events/devices/x11/touch_factory_x11.cc
|
| diff --git a/ui/events/devices/x11/touch_factory_x11.cc b/ui/events/devices/x11/touch_factory_x11.cc
|
| index e9b719907e2d3dddbe06804178a70436424f273d..cd699e5700ff9c55506451268bd66cb64d33456c 100644
|
| --- a/ui/events/devices/x11/touch_factory_x11.cc
|
| +++ b/ui/events/devices/x11/touch_factory_x11.cc
|
| @@ -129,7 +129,7 @@ void TouchFactory::UpdateDeviceList(Display* display) {
|
| reinterpret_cast<XITouchClassInfo*>(xiclassinfo);
|
| // Only care direct touch device (such as touch screen) right now
|
| if (tci->mode == XIDirectTouch)
|
| - CacheTouchscreenIds(display, devinfo.deviceid);
|
| + CacheTouchscreenIds(devinfo.deviceid);
|
| }
|
| }
|
| }
|
| @@ -294,43 +294,19 @@ void TouchFactory::SetPointerDeviceForTest(
|
| }
|
| }
|
|
|
| -void TouchFactory::CacheTouchscreenIds(Display* display, int device_id) {
|
| - XDevice* device = XOpenDevice(display, device_id);
|
| - if (!device)
|
| +void TouchFactory::CacheTouchscreenIds(int device_id) {
|
| + if (!DeviceDataManager::HasInstance())
|
| return;
|
| -
|
| - Atom actual_type_return;
|
| - int actual_format_return;
|
| - unsigned long nitems_return;
|
| - unsigned long bytes_after_return;
|
| - unsigned char *prop_return;
|
| -
|
| - const char kDeviceProductIdString[] = "Device Product ID";
|
| - Atom device_product_id_atom =
|
| - XInternAtom(display, kDeviceProductIdString, false);
|
| -
|
| - if (device_product_id_atom != None &&
|
| - XGetDeviceProperty(display, device, device_product_id_atom, 0, 2,
|
| - False, XA_INTEGER, &actual_type_return,
|
| - &actual_format_return, &nitems_return,
|
| - &bytes_after_return, &prop_return) == Success) {
|
| - if (actual_type_return == XA_INTEGER &&
|
| - actual_format_return == 32 &&
|
| - nitems_return == 2) {
|
| - // An actual_format_return of 32 implies that the returned data is an
|
| - // array of longs. See the description of |prop_return| in `man
|
| - // XGetDeviceProperty` for details.
|
| - long* ptr = reinterpret_cast<long*>(prop_return);
|
| -
|
| - // Internal displays will have a vid and pid of 0. Ignore them.
|
| - // ptr[0] is the vid, and ptr[1] is the pid.
|
| - if (ptr[0] || ptr[1])
|
| - touchscreen_ids_.insert(std::make_pair(ptr[0], ptr[1]));
|
| - }
|
| - XFree(prop_return);
|
| - }
|
| -
|
| - XCloseDevice(display, device);
|
| + std::vector<TouchscreenDevice> touchscreens =
|
| + DeviceDataManager::GetInstance()->touchscreen_devices();
|
| + const auto it =
|
| + std::find_if(touchscreens.begin(), touchscreens.end(),
|
| + [device_id](const TouchscreenDevice& touchscreen) {
|
| + return touchscreen.id == device_id;
|
| + });
|
| + // Internal displays will have a vid and pid of 0. Ignore them.
|
| + if (it != touchscreens.end() && it->vendor_id && it->product_id)
|
| + touchscreen_ids_.insert(std::make_pair(it->vendor_id, it->product_id));
|
| }
|
|
|
| } // namespace ui
|
|
|