Issue 1073523005: Fix Views Textfield drag selection behavior past edges.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1073523005: Fix Views Textfield drag selection behavior past edges. (Closed)

Created:
5 years, 8 months ago by msw

Modified:
5 years, 8 months ago

Reviewers:
Peter Kasting

CC:
chromium-reviews, yusukes+watch_chromium.org, tfarina, shuchen+watch_chromium.org, penghuang+watch_chromium.org, nona+watch_chromium.org, James Su

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Fix Views Textfield drag selection behavior past edges. Immediately select through the edge on external drags. Fix minor OBO for external bounds checking. BUG=415907 TEST=Quickly dragging outside the textfield immediately selects visible text. R=pkasting@chromium.org Committed: https://crrev.com/4ea2e706f097fc960dfa8863b672f44379c58846 Cr-Commit-Position: refs/heads/master@{#324395}

Patch Set 1 #

Patch Set 2 : Support dragging to the right edge too. #

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -2 lines)			Patch
	M	ui/views/controls/textfield/textfield.cc	View	1	1 chunk	+5 lines, -2 lines	0 comments	Download

Messages

Total messages: 6 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1073523005/20001

5 years, 8 months ago (2015-04-09 06:47:25 UTC) #4

commit-bot: I haz the power

5 years, 8 months ago (2015-04-09 08:17:59 UTC) #6

Message was sent while issue was closed.

Patchset 2 (id:??) landed as
https://crrev.com/4ea2e706f097fc960dfa8863b672f44379c58846
Cr-Commit-Position: refs/heads/master@{#324395}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages