Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Issue 1073523004: Part 7 of 8: Move blink images to their own grd/pak file. (Closed)

Created:
5 years, 8 months ago by Elliot Glaysher
Modified:
5 years, 8 months ago
Reviewers:
jam, sky
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Part 7 of 8: Move blink images to their own grd/pak file. This moves the image IDRs used on the chrome side back from IDR2_ to the IDR_ versions. (The next and final patch will remove the IDR2_s from webkit.) BUG=471609, 467176 Committed: https://crrev.com/9f7f233a6d875fc7cb99785ab40b51089e029016 Cr-Commit-Position: refs/heads/master@{#324401}

Patch Set 1 #

Patch Set 2 : Forgot these two. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -100 lines) Patch
M content/child/blink_platform_impl.cc View 1 chunk +50 lines, -50 lines 0 comments Download
M content/shell/common/shell_content_client.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/services/html_viewer/blink_resource_constants.h View 1 chunk +48 lines, -48 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
Elliot Glaysher
5 years, 8 months ago (2015-04-08 18:28:52 UTC) #2
sky
LGTM
5 years, 8 months ago (2015-04-08 19:25:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1073523004/1
5 years, 8 months ago (2015-04-08 19:39:06 UTC) #5
Elliot Glaysher
+jam for content changes.
5 years, 8 months ago (2015-04-08 21:14:26 UTC) #8
jam
lgtm
5 years, 8 months ago (2015-04-09 06:18:43 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1073523004/20001
5 years, 8 months ago (2015-04-09 06:18:57 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-09 08:57:08 UTC) #13
commit-bot: I haz the power
5 years, 8 months ago (2015-04-09 08:57:57 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9f7f233a6d875fc7cb99785ab40b51089e029016
Cr-Commit-Position: refs/heads/master@{#324401}

Powered by Google App Engine
This is Rietveld 408576698