Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(952)

Issue 1073513002: Fix to proper error type on SpeechRecognition (Closed)

Created:
5 years, 8 months ago by deejay
Modified:
5 years, 8 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix to proper error type on SpeechRecognition Spec draft proposal : https://dvcs.w3.org/hg/speech-api/raw-file/tip/webspeechapi.html#speechreco-error We need to add below error types. - NOT_ALLOWED, SERVICE_NOT_ALLOWED, LANGUAGE_NOT_SUPPORTED Also, We change to order of SpeechRecognitionError same as latest spec. BUG=none Committed: https://crrev.com/99db7e04583c04434aa10cdceb6df0612c51db96 Cr-Commit-Position: refs/heads/master@{#326240}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -15 lines) Patch
M content/browser/speech/google_streaming_remote_engine.cc View 1 chunk +3 lines, -6 lines 0 comments Download
M content/public/common/speech_recognition_error.h View 2 chunks +12 lines, -5 lines 0 comments Download
M content/renderer/speech_recognition_dispatcher.cc View 2 chunks +8 lines, -4 lines 0 comments Download

Messages

Total messages: 22 (6 generated)
deejay
Hi hans, tommi. This patch is for fixing to proper error type on SpeechRecognition. Please ...
5 years, 8 months ago (2015-04-08 16:30:06 UTC) #2
deejay
On 2015/04/08 16:30:06, deejay wrote: > Hi hans, tommi. > This patch is for fixing ...
5 years, 8 months ago (2015-04-10 07:07:26 UTC) #3
deejay
+ add more reviewer. Dear dmazzoni, dtseng. Is it possible to review about patch for ...
5 years, 8 months ago (2015-04-13 15:52:48 UTC) #5
deejay
On 2015/04/13 15:52:48, deejay wrote: > + add more reviewer. > > Dear dmazzoni, dtseng. ...
5 years, 8 months ago (2015-04-20 14:41:40 UTC) #6
tommi (sloooow) - chröme
lgtm
5 years, 8 months ago (2015-04-20 16:20:30 UTC) #7
gshires1
lgtm
5 years, 8 months ago (2015-04-20 20:15:55 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1073513002/1
5 years, 8 months ago (2015-04-21 01:22:29 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/57601)
5 years, 8 months ago (2015-04-21 01:31:08 UTC) #12
deejay
On 2015/04/21 01:31:08, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
5 years, 8 months ago (2015-04-21 06:20:37 UTC) #14
Charlie Reis
LGTM. In the CL description, the BUG= line should point to a Chromium bug number, ...
5 years, 8 months ago (2015-04-21 17:04:49 UTC) #15
deejay
On 2015/04/21 17:04:49, Charlie Reis wrote: > LGTM. > > In the CL description, the ...
5 years, 8 months ago (2015-04-22 05:56:37 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1073513002/1
5 years, 8 months ago (2015-04-22 05:57:07 UTC) #18
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-22 07:23:20 UTC) #19
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/99db7e04583c04434aa10cdceb6df0612c51db96 Cr-Commit-Position: refs/heads/master@{#326240}
5 years, 8 months ago (2015-04-22 07:24:12 UTC) #20
Charlie Reis
On 2015/04/22 05:56:37, deejay wrote: > On 2015/04/21 17:04:49, Charlie Reis wrote: > > LGTM. ...
5 years, 8 months ago (2015-04-22 16:44:31 UTC) #21
deejay
5 years, 8 months ago (2015-04-23 02:09:08 UTC) #22
Message was sent while issue was closed.
On 2015/04/22 16:44:31, Charlie Reis wrote:
> On 2015/04/22 05:56:37, deejay wrote:
> > On 2015/04/21 17:04:49, Charlie Reis wrote:
> > > LGTM.
> > > 
> > > In the CL description, the BUG= line should point to a Chromium bug
number,
> > not
> > > the spec URL.  Let's put the spec URL earlier in the CL description.  It
> looks
> > > like 116954 is the relevant bug number.
> > > 
> > > Also s/lastest/latest/
> > 
> > Thanks for reviewing!
> > I've updated on commit msg.
> 
> I asked you to use 116954 on the BUG line.  Too late to fix it now, but please
> try to list an actual bug number in future CLs.

Dear Charlie Reis.

Sorry!
I've miss understanding.

If I have similar updating after, I will fill BUG id in commit msg.

Powered by Google App Engine
This is Rietveld 408576698