Issue 1073483002: Make --undefok a little louder now that we're using it all the time.

Issue 1073483002: Make --undefok a little louder now that we're using it all the time. (Closed)

Created:
5 years, 8 months ago by mtklein_C

Modified:
5 years, 8 months ago

Reviewers:
borenet

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

Make --undefok a little louder now that we're using it all the time. BUG=skia: Committed: https://skia.googlesource.com/skia/+/929f63feccf500283571077586dbbd69c206bf13

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -2 lines)			Patch
	M	tools/flags/SkCommandLineFlags.cpp	View		1 chunk	+4 lines, -2 lines	0 comments	Download

Total messages: 8 (2 generated)

mtklein_C

This is a proposed followup to https://codereview.chromium.org/1072483002/ if we land it.

5 years, 8 months ago (2015-04-08 14:48:52 UTC) #3

borenet

Code change LGTM but I don't know how much this helps us since we almost ...

5 years, 8 months ago (2015-04-08 14:54:23 UTC) #4

mtklein_C

On 2015/04/08 14:54:23, borenet wrote: > Code change LGTM but I don't know how much ...

5 years, 8 months ago (2015-04-08 15:07:14 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1073483002/1

5 years, 8 months ago (2015-04-08 15:07:34 UTC) #7

commit-bot: I haz the power

5 years, 8 months ago (2015-04-08 15:30:41 UTC) #8

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/929f63feccf500283571077586dbbd69c206bf13