Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(417)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1073473002: change isNestedRect to isNestedFillRect (Closed)

Created:
5 years, 8 months ago by caryclark
Modified:
5 years, 8 months ago
Reviewers:
bsalomon, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

change isNestedRect to isNestedFillRect R=reed@google.com, bsalomon@google.com Let isNested(Fill)Rect return true if drawn path describes filled rectangles. Committed: https://skia.googlesource.com/skia/+/95bc5f349561fef2d6fbae71adb08cf5c2eec0c9

Patch Set 1 #

Patch Set 2 : fix linux error #

Patch Set 3 : fix lua #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -26 lines) Patch
M include/core/SkPath.h View 2 chunks +3 lines, -2 lines 0 comments Download
M src/core/SkMaskFilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkPath.cpp View 1 5 chunks +17 lines, -3 lines 0 comments Download
M src/gpu/GrContext.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/utils/SkLua.cpp View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M tests/PathTest.cpp View 1 12 chunks +29 lines, -14 lines 0 comments Download
M tests/StrokeTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tools/lua/scrape.lua View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 18 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1073473002/1
5 years, 8 months ago (2015-04-08 14:41:23 UTC) #2
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu-GCC-Arm7-Debug-Android-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm7-Debug-Android-Trybot/builds/379) Build-Ubuntu-GCC-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED, ...
5 years, 8 months ago (2015-04-08 14:42:47 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1073473002/20001
5 years, 8 months ago (2015-04-08 14:45:01 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu-GCC-Arm7-Debug-Android-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm7-Debug-Android-Trybot/builds/381)
5 years, 8 months ago (2015-04-08 14:46:44 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1073473002/40001
5 years, 8 months ago (2015-04-08 14:50:51 UTC) #10
caryclark
patch ready for review
5 years, 8 months ago (2015-04-08 14:59:49 UTC) #11
reed1
lgtm
5 years, 8 months ago (2015-04-08 15:00:09 UTC) #12
commit-bot: I haz the power
This issue passed the CQ dry run.
5 years, 8 months ago (2015-04-08 15:03:13 UTC) #14
bsalomon
lgtm
5 years, 8 months ago (2015-04-08 15:32:39 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1073473002/40001
5 years, 8 months ago (2015-04-08 15:34:02 UTC) #17
commit-bot: I haz the power
5 years, 8 months ago (2015-04-08 15:34:23 UTC) #18
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/95bc5f349561fef2d6fbae71adb08cf5c2eec0c9

Powered by Google App Engine
This is Rietveld 408576698