chrome/browser/renderer_host/chrome_render_widget_host_view_mac_history_swiper.mm - Issue 107343008: mac: Fix a history swiper bug where the shield wouldn't disappear.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/renderer_host/chrome_render_widget_host_view_mac_history_swiper.mm

Issue 107343008: mac: Fix a history swiper bug where the shield wouldn't disappear. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase against top of tree. Created 6 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/renderer_host/chrome_render_widget_host_view_mac_history_swiper.mm

diff --git a/chrome/browser/renderer_host/chrome_render_widget_host_view_mac_history_swiper.mm b/chrome/browser/renderer_host/chrome_render_widget_host_view_mac_history_swiper.mm

index ac57d05d0939167fcbee940357c2764e7ba4b164..58f9e46b8590bad4b558c65f1d9da1c7172883bf 100644

--- a/chrome/browser/renderer_host/chrome_render_widget_host_view_mac_history_swiper.mm

+++ b/chrome/browser/renderer_host/chrome_render_widget_host_view_mac_history_swiper.mm

@@ -246,7 +246,7 @@

? kHistoryOverlayModeForward

: kHistoryOverlayModeBack];

[historyOverlay showPanelForView:[delegate_ viewThatWantsHistoryOverlay]];

- historyOverlay_ = [historyOverlay retain];

+ historyOverlay_ = historyOverlay;

// Record whether the user was swiping forwards or backwards.

historySwipeDirection_ = direction;

« no previous file with comments | « no previous file | chrome/browser/ui/cocoa/history_overlay_controller.mm » ('j') | no next file with comments »