Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(364)

Unified Diff: pkg/analysis_server/lib/src/edit/edit_domain.dart

Issue 1073383002: Create a public API for contributing assists and make assists pluggable (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Address comments Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analysis_server/lib/plugin/assist.dart ('k') | pkg/analysis_server/lib/src/plugin/server_plugin.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/lib/src/edit/edit_domain.dart
diff --git a/pkg/analysis_server/lib/src/edit/edit_domain.dart b/pkg/analysis_server/lib/src/edit/edit_domain.dart
index 4536adbdd7a973936e71287e21d399347e818106..32effe1899dac203bf77adf4eefb3d8a285fd891 100644
--- a/pkg/analysis_server/lib/src/edit/edit_domain.dart
+++ b/pkg/analysis_server/lib/src/edit/edit_domain.dart
@@ -6,6 +6,7 @@ library edit.domain;
import 'dart:async';
+import 'package:analysis_server/edit/assist/assist_core.dart';
import 'package:analysis_server/edit/fix/fix_core.dart';
import 'package:analysis_server/src/analysis_server.dart';
import 'package:analysis_server/src/collections.dart';
@@ -114,18 +115,18 @@ class EditDomainHandler implements RequestHandler {
}
Response getAssists(Request request) {
- var params = new EditGetAssistsParams.fromRequest(request);
+ EditGetAssistsParams params = new EditGetAssistsParams.fromRequest(request);
+ ContextSourcePair pair = server.getContextSourcePair(params.file);
+ engine.AnalysisContext context = pair.context;
+ Source source = pair.source;
List<SourceChange> changes = <SourceChange>[];
- List<CompilationUnit> units =
- server.getResolvedCompilationUnits(params.file);
- if (units.isNotEmpty) {
- CompilationUnit unit = units[0];
- List<Assist> assists = computeAssists(unit, params.offset, params.length);
+ if (context != null && source != null) {
+ List<Assist> assists = computeAssists(plugin, context,
+ source, params.offset, params.length);
assists.forEach((Assist assist) {
changes.add(assist.change);
});
}
- // respond
return new EditGetAssistsResult(changes).toResponse(request.id);
}
« no previous file with comments | « pkg/analysis_server/lib/plugin/assist.dart ('k') | pkg/analysis_server/lib/src/plugin/server_plugin.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698