pkg/analysis_server/lib/src/edit/edit_domain.dart - Issue 1073383002: Create a public API for contributing assists and make assists pluggable

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/lib/src/edit/edit_domain.dart

Issue 1073383002: Create a public API for contributing assists and make assists pluggable (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/analysis_server/lib/plugin/assist.dart ('k') | pkg/analysis_server/lib/src/plugin/server_plugin.dart » ('j') | pkg/analysis_server/lib/src/services/correction/assist.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analysis_server/lib/src/edit/edit_domain.dart

diff --git a/pkg/analysis_server/lib/src/edit/edit_domain.dart b/pkg/analysis_server/lib/src/edit/edit_domain.dart

index 4536adbdd7a973936e71287e21d399347e818106..46e9b57750f283b234305bb7507f9bb86cdf2515 100644

--- a/pkg/analysis_server/lib/src/edit/edit_domain.dart

+++ b/pkg/analysis_server/lib/src/edit/edit_domain.dart

@@ -6,6 +6,7 @@ library edit.domain;

import 'dart:async';

+import 'package:analysis_server/edit/assist/assist_core.dart';

import 'package:analysis_server/edit/fix/fix_core.dart';

import 'package:analysis_server/src/analysis_server.dart';

import 'package:analysis_server/src/collections.dart';

@@ -120,7 +121,9 @@ class EditDomainHandler implements RequestHandler {

server.getResolvedCompilationUnits(params.file);

if (units.isNotEmpty) {

CompilationUnit unit = units[0];

- List<Assist> assists = computeAssists(unit, params.offset, params.length);

+ CompilationUnitElement element = unit.element;

scheglov 2015/04/11 00:25:01 If we don't actually use CompilationUnit here (and

Brian Wilkerson 2015/04/13 15:17:58 I've made the change here, we can clean up getFixe

+ List<Assist> assists = computeAssists(plugin, element.context,

+ element.source, params.offset, params.length);

assists.forEach((Assist assist) {

changes.add(assist.change);

});