Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 1073293002: [sql] Remove fts2 patches. (Closed)

Created:
5 years, 8 months ago by Scott Hess - ex-Googler
Modified:
5 years, 8 months ago
Reviewers:
michaeln
CC:
chromium-reviews, jshin+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[sql] Remove fts2 patches. Chromium's has not built fts2 for a few weeks with no problems reported, seems safe to remove the patches for M-44. SQLITE_CORE was only needed to compile the fts2 files independently from the amalgamation. The README.chromium changes were leftovers from the big import that I'm arbitrarily dropping here. BUG=455817 Committed: https://crrev.com/0450d83829cb86ffb625cb8248a612dcb0e1d1fd Cr-Commit-Position: refs/heads/master@{#325245}

Patch Set 1 #

Patch Set 2 : Put back SQLITE_CORE only for the icu component for iOS #

Unified diffs Side-by-side diffs Delta from patch set Stats (+278 lines, -2970 lines) Patch
M third_party/sqlite/BUILD.gn View 1 2 chunks +4 lines, -1 line 0 comments Download
M third_party/sqlite/README.chromium View 3 chunks +8 lines, -6 lines 0 comments Download
M third_party/sqlite/patches/0001-test-SQLite-tests-compiling-on-Linux.patch View 2 chunks +1 line, -2 lines 0 comments Download
D third_party/sqlite/patches/0010-fts2-test-Add-fts2-to-testfixture.patch View 1 chunk +0 lines, -107 lines 0 comments Download
D third_party/sqlite/patches/0011-fts2-Disable-fts2_tokenizer-for-security-reasons.patch View 1 chunk +0 lines, -53 lines 0 comments Download
D third_party/sqlite/patches/0012-fts2-backport-ICU-tokenizer-iterate-by-UTF16.patch View 1 chunk +0 lines, -29 lines 0 comments Download
D third_party/sqlite/patches/0013-fts2-Interpret-foo-as-a-prefix-search.patch View 1 chunk +0 lines, -48 lines 0 comments Download
D third_party/sqlite/patches/0014-fts2-Detect-and-handle-certain-corruption-cases.patch View 1 chunk +0 lines, -309 lines 0 comments Download
D third_party/sqlite/patches/0015-fts2-Fix-a-crasher-in-full-text-search-sqlite.patch View 1 chunk +0 lines, -89 lines 0 comments Download
D third_party/sqlite/patches/0016-fts2-Fix-numerous-out-of-bounds-bugs-reading-corrupt.patch View 1 chunk +0 lines, -1611 lines 0 comments Download
M third_party/sqlite/sqlite.gyp View 1 2 chunks +4 lines, -1 line 0 comments Download
M third_party/sqlite/src/Makefile.linux-gcc View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/sqlite/src/ext/fts2/fts2.c View 78 chunks +258 lines, -689 lines 0 comments Download
M third_party/sqlite/src/ext/fts2/fts2_icu.c View 1 chunk +1 line, -1 line 0 comments Download
M third_party/sqlite/src/ext/fts2/fts2_tokenizer.c View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/sqlite/src/main.mk View 3 chunks +1 line, -19 lines 0 comments Download

Messages

Total messages: 18 (7 generated)
Scott Hess - ex-Googler
I figure now that M-43 has branched, might as well finish this off. This caused ...
5 years, 8 months ago (2015-04-10 20:52:13 UTC) #2
michaeln
r/s lgtm
5 years, 8 months ago (2015-04-13 20:12:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1073293002/1
5 years, 8 months ago (2015-04-13 20:18:57 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/14396)
5 years, 8 months ago (2015-04-14 05:38:48 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1073293002/1
5 years, 8 months ago (2015-04-14 05:47:21 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/14550)
5 years, 8 months ago (2015-04-14 12:13:09 UTC) #11
Scott Hess - ex-Googler
Put back SQLITE_CORE only for the icu component for iOS
5 years, 8 months ago (2015-04-15 14:10:01 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1073293002/20001
5 years, 8 months ago (2015-04-15 14:10:45 UTC) #15
Scott Hess - ex-Googler
On 2015/04/15 14:10:01, Scott Hess wrote: > Put back SQLITE_CORE only for the icu component ...
5 years, 8 months ago (2015-04-15 14:11:53 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-15 15:20:54 UTC) #17
commit-bot: I haz the power
5 years, 8 months ago (2015-04-15 15:21:33 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0450d83829cb86ffb625cb8248a612dcb0e1d1fd
Cr-Commit-Position: refs/heads/master@{#325245}

Powered by Google App Engine
This is Rietveld 408576698