Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issue 1073233002: [es6] Fix length property of collection constructors (Closed)

Created:
5 years, 8 months ago by arv (Not doing code reviews)
Modified:
5 years, 8 months ago
Reviewers:
adamk
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[es6] Fix length property of collection constructors {Map, Set, WeakMap, WeakSet}.length should be 0. BUG=v8:4021 LOG=N R=adamk@chromium.org Committed: https://crrev.com/186dd69b3a708171a1309be9509b8985bc20e305 Cr-Commit-Position: refs/heads/master@{#27798}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M src/collection.js View 2 chunks +2 lines, -0 lines 0 comments Download
M src/weak-collection.js View 2 chunks +2 lines, -0 lines 0 comments Download
M test/mjsunit/es6/collections.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
arv (Not doing code reviews)
PTAL
5 years, 8 months ago (2015-04-10 18:07:26 UTC) #1
adamk
lgtm
5 years, 8 months ago (2015-04-13 18:30:43 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1073233002/1
5 years, 8 months ago (2015-04-13 18:33:06 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-13 18:59:47 UTC) #5
commit-bot: I haz the power
5 years, 8 months ago (2015-04-13 18:59:58 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/186dd69b3a708171a1309be9509b8985bc20e305
Cr-Commit-Position: refs/heads/master@{#27798}

Powered by Google App Engine
This is Rietveld 408576698