Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1073133002: Reland "Merge cellspace into old pointer space" (Closed)

Created:
5 years, 8 months ago by Toon Verwaest
Modified:
5 years, 8 months ago
CC:
v8-dev, Yang, Paweł Hajdan Jr.
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland "Merge cellspace into old pointer space" This fixes the arm(64) and mips(64) write barriers BUG= Committed: https://crrev.com/4bd9bdbb28c0f4004b113534bf6082ec4d3385b9 Cr-Commit-Position: refs/heads/master@{#27751}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -223 lines) Patch
M include/v8.h View 2 chunks +2 lines, -3 lines 0 comments Download
M src/api.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M src/arm/code-stubs-arm.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M src/arm64/code-stubs-arm64.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M src/assembler.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/counters.h View 3 chunks +0 lines, -8 lines 0 comments Download
M src/extensions/statistics-extension.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M src/globals.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/heap/heap.h View 4 chunks +12 lines, -18 lines 0 comments Download
M src/heap/heap.cc View 23 chunks +7 lines, -65 lines 0 comments Download
M src/heap/heap-inl.h View 2 chunks +0 lines, -3 lines 0 comments Download
M src/heap/incremental-marking.cc View 3 chunks +0 lines, -6 lines 0 comments Download
M src/heap/mark-compact.h View 2 chunks +3 lines, -0 lines 0 comments Download
M src/heap/mark-compact.cc View 16 chunks +18 lines, -47 lines 0 comments Download
M src/heap/objects-visiting-inl.h View 1 chunk +1 line, -1 line 0 comments Download
M src/heap/spaces.h View 1 chunk +0 lines, -25 lines 0 comments Download
M src/heap/spaces.cc View 3 chunks +0 lines, -12 lines 0 comments Download
M src/heap/store-buffer.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/heap/store-buffer-inl.h View 2 chunks +1 line, -3 lines 0 comments Download
M src/hydrogen-instructions.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/ia32/assembler-ia32-inl.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M src/mips64/code-stubs-mips64.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M src/objects.h View 3 chunks +1 line, -2 lines 0 comments Download
M src/objects-inl.h View 1 chunk +1 line, -11 lines 0 comments Download
M src/snapshot/serialize.h View 1 chunk +8 lines, -4 lines 0 comments Download
M src/snapshot/serialize.cc View 2 chunks +1 line, -2 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Toon Verwaest
PTAL
5 years, 8 months ago (2015-04-10 11:21:44 UTC) #2
Toon Verwaest
balazs.kilvady: can you have a look at the mips part of the write-barrier fix?
5 years, 8 months ago (2015-04-10 11:26:04 UTC) #4
Hannes Payer (out of office)
lgtm
5 years, 8 months ago (2015-04-10 13:04:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1073133002/1
5 years, 8 months ago (2015-04-10 13:11:25 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-10 13:54:17 UTC) #8
commit-bot: I haz the power
5 years, 8 months ago (2015-04-10 13:54:25 UTC) #9
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/4bd9bdbb28c0f4004b113534bf6082ec4d3385b9
Cr-Commit-Position: refs/heads/master@{#27751}

Powered by Google App Engine
This is Rietveld 408576698