Issue 107313004: Remove TreatNullAs=NullString for CSS*Rule

Issue 107313004: Remove TreatNullAs=NullString for CSS*Rule (Closed)

Created:
7 years ago by philipj_slow

Modified:
7 years ago

Reviewers:
arv (Not doing code reviews), jochen (gone - plz use gerrit)

CC:
blink-reviews, arv+blink, dglazkov+blink, apavlov+blink_chromium.org, Inactive, darktears, watchdog-blink-watchlist_google.com

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

Remove TreatNullAs=NullString for CSS*Rule http://dev.w3.org/csswg/cssom/#csscharsetrule http://dev.w3.org/csswg/css-animations/#csskeyframesrule http://dev.w3.org/csswg/cssom/#csspagerule http://dev.w3.org/csswg/cssom/#cssrule http://dev.w3.org/csswg/cssom/#cssstylerule The tests for the updated properties pass in Firefox Nightly, IE11 Release Preview and Opera 12.16, with these exceptions: Firefox reflects CSSCharsetRule.encoding, CSSKeyframesRule.name, and CSSPageRule.selectorText as null, and ignores setting CSSStyleRule.selectorText. IE doesn't support CSSCharsetRule, throws an exception when setting CSSPageRule.selectorText and ignores setting CSSStyleRule.selectorText. Opera throws an exception when setting CSSRule.cssText, ignores setting CSSCharsetRule.encoding and throws an exception when setting CSSPageRule.selectorText. This is not very impressive, but since there is no attribute for which all the other browsers agree, just going with the spec seems sound. BUG=310298 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=163424

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+51 lines, -37 lines)			Patch
M	LayoutTests/fast/dom/css-element-attribute-js-null.html	View	4 chunks	+38 lines, -19 lines	0 comments	Download
M	LayoutTests/fast/dom/css-element-attribute-js-null-expected.txt	View	1 chunk	+7 lines, -1 line	0 comments	Download
M	Source/core/css/CSSCharsetRule.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/css/CSSCharsetRule.idl	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	Source/core/css/CSSKeyframesRule.idl	View	2 chunks	+1 line, -3 lines	0 comments	Download
M	Source/core/css/CSSPageRule.idl	View	1 chunk	+1 line, -5 lines	0 comments	Download
M	Source/core/css/CSSRule.idl	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/css/CSSStyleRule.idl	View	1 chunk	+1 line, -5 lines	0 comments	Download

Total messages: 5 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/107313004/1

7 years ago (2013-12-09 09:16:55 UTC) #3

Message was sent while issue was closed.

LGTM