Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 1073123002: Speculative fix for stack overflow in CollectEvacuationCandidates (Closed)

Created:
5 years, 8 months ago by Jakob Kummerow
Modified:
5 years, 8 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Speculative fix for stack overflow in CollectEvacuationCandidates I don't have a repro, but it seems that when we are close to the stack limit, CollectEvacuationCandidates' local variables can blow the limit. To avoid this, instead of always allocating a 2000-pointer-sizes array on the stack, use a std::vector (which stores its elements on the heap), and while we're at it, only allocate as many elements as we actually need. Committed: https://crrev.com/052924abe3fb44df588f6e7c7df9ca691bbfa887 Cr-Commit-Position: refs/heads/master@{#27742}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -10 lines) Patch
M src/heap/mark-compact.cc View 3 chunks +11 lines, -10 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Jakob Kummerow
As discussed. PTAL.
5 years, 8 months ago (2015-04-10 10:43:36 UTC) #2
Hannes Payer (out of office)
lgtm
5 years, 8 months ago (2015-04-10 11:00:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1073123002/1
5 years, 8 months ago (2015-04-10 11:01:36 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-10 11:24:30 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-10 11:24:35 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/052924abe3fb44df588f6e7c7df9ca691bbfa887
Cr-Commit-Position: refs/heads/master@{#27742}

Powered by Google App Engine
This is Rietveld 408576698