Issue 1073113004: Added an env variable to hide "Depot tools has been updated..." message

Issue 1073113004: Added an env variable to hide "Depot tools has been updated..." message (Closed)

Created:
5 years, 8 months ago by Sergiy Byelozyorov

Modified:
5 years, 8 months ago

Reviewers:
Adrian Kuegel, ghost stip (do not use)

CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org, Adrian Kuegel

Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master

Target Ref:
refs/heads/master

Project:
tools

Visibility:
Public.

More Reviews

Description

Added an env variable to hide "Depot tools has been updated..." message This is needed to prevent auto_deploy.py in CQ send alert each time depot_tools get's updated as cron job will send alert on any output. R=stip@chromium.org CC=akuegel@chromium.org BUG=475049 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=294778

Patch Set 1 #

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	update_depot_tools	View		1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 9 (3 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1073113004/1

5 years, 8 months ago (2015-04-13 09:53:35 UTC) #4

commit-bot: I haz the power

Presubmit check for 1073113004-1 failed and returned exit status 1. Running presubmit commit checks ...

5 years, 8 months ago (2015-04-13 09:55:29 UTC) #6

Presubmit check for 1073113004-1 failed and returned exit status 1.

Running presubmit commit checks ...
Checking out rietveld...
Running save-description-on-failure.sh
Running push-basic.sh
Running upstream.sh
Running submit-from-new-dir.sh
Running abandon.sh
Running submodule-merge-test.sh
Running upload-local-tracking-branch.sh
Running hooks.sh
Running post-dcommit-hook-test.sh
Running upload-stale.sh
Running patch.sh
Running basic.sh

** Presubmit ERRORS **
tests/gclient_smoketest.py (55.13s) failed
Ffatal: reference is not a tree: 0512adf30f4e1b6652c784f449f69f2d06e8b82d
EE..............................................
======================================================================
ERROR: testBlinkDEPSChangeUsingGit (__main__.BlinkDEPSTransitionSmokeTest)
Like testBlinkDEPSChangeUsingGclient, but move the main project using
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/gclient_smoketest.py", line 1630, in testBlinkDEPSChangeUsingGit
    cwd=self.checkout_path)
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/subprocess2.py", line
484, in check_call
    check_call_out(args, **kwargs)
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/subprocess2.py", line
478, in check_call_out
    returncode, args, kwargs.get('cwd'), out[0], out[1])
CalledProcessError: Command git checkout -q
0512adf30f4e1b6652c784f449f69f2d06e8b82d returned non-zero exit status 128 in
/tmp/trialQ0oDDq/__main__.BlinkDEPSTransitionSmokeTest.testBlinkDEPSChangeUsingGit/src

======================================================================
ERROR: testBlinkLocalBranchesArePreserved
(__main__.BlinkDEPSTransitionSmokeTest)
Checks that the state of local git branches are effectively preserved
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/gclient_smoketest.py", line 1656, in
testBlinkLocalBranchesArePreserved
    self.CheckStatusPreMergePoint()
  File "tests/gclient_smoketest.py", line 1558, in CheckStatusPreMergePoint
    self.blink), self.blink_git_url)
  File "/b/infra_internal/commit_queue/workdir/tools/depot_tools/scm.py", line
121, in Capture
    cwd=cwd, stderr=subprocess2.PIPE, env=env, **kwargs)
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/subprocess2.py", line
515, in check_output
    return check_call_out(args, stdout=PIPE, **kwargs)[0]
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/subprocess2.py", line
475, in check_call_out
    out, returncode = communicate(args, **kwargs)
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/subprocess2.py", line
449, in communicate
    proc = Popen(args, **kwargs)
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/subprocess2.py", line
253, in __init__
    % (str(e), kwargs.get('cwd'), args[0]))
OSError: Execution failed with error: [Errno 2] No such file or directory:
'/tmp/trialQ0oDDq/__main__.BlinkDEPSTransitionSmokeTest.testBlinkLocalBranchesArePreserved/src/third_party/WebKit'.
Check that
/tmp/trialQ0oDDq/__main__.BlinkDEPSTransitionSmokeTest.testBlinkLocalBranchesArePreserved/src/third_party/WebKit
or git exist and have execution permission.

======================================================================
FAIL: testBlinkDEPSChangeUsingGclient (__main__.BlinkDEPSTransitionSmokeTest)
Checks that {src,blink} repos are consistent when syncing going back and
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/gclient_smoketest.py", line 1601, in
testBlinkDEPSChangeUsingGclient
    self.assertEqual(res[2], 0, 'DEPS change sync failed.')
AssertionError: DEPS change sync failed.

----------------------------------------------------------------------
Ran 49 tests in 54.929s

FAILED (failures=1, errors=2)


tests/git_cl_test.py (0.54s) failed
.......ERROR: Gerrit commit-msg hook not available.
..ERROR:root:@11  Expected: (['git', 'config', 'branch.master.rietveldissue'],) 
 Actual: (['git', 'rev-parse', '--verify', 'fake_ancestor_sha'],)
FERROR:root:@11  Expected: (['git', 'config', 'branch.master.rietveldissue'],)  
Actual: (['git', 'rev-parse', '--verify', 'fake_ancestor_sha'],)
FERROR:root:@11  Expected: (['git', 'config', 'branch.master.rietveldissue'],)  
Actual: (['git', 'rev-parse', '--verify', 'fake_ancestor_sha'],)
FERROR:root:@11  Expected: (['git', 'config', 'branch.master.rietveldissue'],)  
Actual: (['git', 'rev-parse', '--verify', 'fake_ancestor_sha'],)
FERROR:root:@11  Expected: (['git', 'config', 'branch.master.rietveldissue'],)  
Actual: (['git', 'rev-parse', '--verify', 'fake_ancestor_sha'],)
FERROR:root:@11  Expected: (['git', 'config', 'branch.master.rietveldissue'],)  
Actual: (['git', 'rev-parse', '--verify', 'fake_ancestor_sha'],)
FERROR:root:@11  Expected: (['git', 'config', 'branch.master.rietveldissue'],)  
Actual: (['git', 'rev-parse', '--verify', 'fake_ancestor_sha'],)
FERROR:root:@11  Expected: (['git', 'config', 'branch.master.rietveldissue'],)  
Actual: (['git', 'rev-parse', '--verify', 'fake_ancestor_sha'],)
FERROR:root:@11  Expected: (['git', 'config', 'branch.master.rietveldissue'],)  
Actual: (['git', 'rev-parse', '--verify', 'fake_ancestor_sha'],)
F.
======================================================================
FAIL: test_keep_find_copies (__main__.TestGitCl)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/git_cl_test.py", line 449, in test_keep_find_copies
    [])
  File "tests/git_cl_test.py", line 425, in _run_reviewer_test
    git_cl.main(['upload'] + upload_args)
  File "/b/infra_internal/commit_queue/workdir/tools/depot_tools/git_cl.py",
line 3190, in main
    return dispatcher.execute(OptionParser(), argv)
  File "/b/infra_internal/commit_queue/workdir/tools/depot_tools/subcommand.py",
line 252, in execute
    return command(parser, args[1:])
  File "/b/infra_internal/commit_queue/workdir/tools/depot_tools/git_cl.py",
line 2075, in CMDupload
    change = cl.GetChange(base_branch, None)
  File "/b/infra_internal/commit_queue/workdir/tools/depot_tools/git_cl.py",
line 845, in GetChange
    if not self.GitSanityChecks(upstream_branch):
  File "/b/infra_internal/commit_queue/workdir/tools/depot_tools/git_cl.py",
line 662, in GitSanityChecks
    upstream_sha = RunGit(['rev-parse', '--verify', upstream_git_obj]).strip()
  File "/b/infra_internal/commit_queue/workdir/tools/depot_tools/git_cl.py",
line 102, in RunGit
    return RunCommand(['git'] + args, **kwargs)
  File "/b/infra_internal/commit_queue/workdir/tools/depot_tools/git_cl.py",
line 90, in RunCommand
    return subprocess2.check_output(args, shell=False, **kwargs)
  File "tests/git_cl_test.py", line 118, in _mocked_call
    self.fail(msg)
AssertionError: @11  Expected: (['git', 'config',
'branch.master.rietveldissue'],)   Actual: (['git', 'rev-parse', '--verify',
'fake_ancestor_sha'],)

======================================================================
FAIL: test_keep_similarity (__main__.TestGitCl)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/git_cl_test.py", line 441, in test_keep_similarity
    [])
  File "tests/git_cl_test.py", line 425, in _run_reviewer_test
    git_cl.main(['upload'] + upload_args)
  File "/b/infra_internal/commit_queue/workdir/tools/depot_tools/git_cl.py",
line 3190, in main
    return dispatcher.execute(OptionParser(), argv)
  File "/b/infra_internal/commit_queue/workdir/tools/depot_tools/subcommand.py",
line 252, in execute
    return command(parser, args[1:])
  File "/b/infra_internal/commit_queue/workdir/tools/depot_tools/git_cl.py",
line 2075, in CMDupload
    change = cl.GetChange(base_branch, None)
  File "/b/infra_internal/commit_queue/workdir/tools/depot_tools/git_cl.py",
line 845, in GetChange
    if not self.GitSanityChecks(upstream_branch):
  File "/b/infra_internal/commit_queue/workdir/tools/depot_tools/git_cl.py",
line 662, in GitSanityChecks
    upstream_sha = RunGit(['rev-parse', '--verify', upstream_git_obj]).strip()
  File "/b/infra_internal/commit_queue/workdir/tools/depot_tools/git_cl.py",
line 102, in RunGit
    return RunCommand(['git'] + args, **kwargs)
  File "/b/infra_internal/commit_queue/workdir/tools/depot_tools/git_cl.py",
line 90, in RunCommand
    return subprocess2.check_output(args, shell=False, **kwargs)
  File "tests/git_cl_test.py", line 118, in _mocked_call
    self.fail(msg)
AssertionError: @11  Expected: (['git', 'config',
'branch.master.rietveldissue'],)   Actual: (['git', 'rev-parse', '--verify',
'fake_ancestor_sha'],)

======================================================================
FAIL: test_no_reviewer (__main__.TestGitCl)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/git_cl_test.py", line 433, in test_no_reviewer
    [])
  File "tests/git_cl_test.py", line 425, in _run_reviewer_test
    git_cl.main(['upload'] + upload_args)
  File "/b/infra_internal/commit_queue/workdir/tools/depot_tools/git_cl.py",
line 3190, in main
    return dispatcher.execute(OptionParser(), argv)
  File "/b/infra_internal/commit_queue/workdir/tools/depot_tools/subcommand.py",
line 252, in execute
    return command(parser, args[1:])
  File "/b/infra_internal/commit_queue/workdir/tools/depot_tools/git_cl.py",
line 2075, in CMDupload
    change = cl.GetChange(base_branch, None)
  File "/b/infra_internal/commit_queue/workdir/tools/depot_tools/git_cl.py",
line 845, in GetChange
    if not self.GitSanityChecks(upstream_branch):
  File "/b/infra_internal/commit_queue/workdir/tools/depot_tools/git_cl.py",
line 662, in GitSanityChecks
    upstream_sha = RunGit(['rev-parse', '--verify', upstream_git_obj]).strip()
  File "/b/infra_internal/commit_queue/workdir/tools/depot_tools/git_cl.py",
line …
(message too large)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1073113004/1

5 years, 8 months ago (2015-04-13 14:02:06 UTC) #8

commit-bot: I haz the power

5 years, 8 months ago (2015-04-13 14:03:54 UTC) #9

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=294778

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages