Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 1073103004: Revert of Revert of [strong] checking of this & super in constructors (Closed)

Created:
5 years, 8 months ago by Michael Achenbach
Modified:
5 years, 8 months ago
CC:
v8-dev, arv (Not doing code reviews)
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Revert of [strong] checking of this & super in constructors (patchset #1 id:1 of https://codereview.chromium.org/1105453002/) Reason for revert: Was an infrastructure problem. Original issue's description: > Revert of [strong] checking of this & super in constructors (patchset #7 id:110001 of https://codereview.chromium.org/1024063002/) > > Reason for revert: > [Sheriff] Breaks mac gc stress: > http://build.chromium.org/p/client.v8/builders/V8%20Mac%20GC%20Stress/builds/1024 > > Original issue's description: > > [strong] checking of this & super in constructors > > > > R=dslomov@chromium.org, marja@chromium.org > > BUG=v8:3956 > > LOG=N > > > > Enforces for constructors that > > - the only use of 'super' is the super constructor call > > - the only use of 'this' is a property assignment > > - both of these must happen at the top-level of the body > > - 'this' may only be assigned after the 'super' call > > - 'return' may only be used after the last assignment to 'this' > > > > Not yet working for arrow functions (there might be deeper bugs with those). > > > > Committed: https://crrev.com/580d66bcda66220d2f3062ac58daf925436df74c > > Cr-Commit-Position: refs/heads/master@{#27977} > > TBR=dslomov@chromium.org,marja@chromium.org,conradw@chromium.org,rossberg@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=v8:3956 TBR=dslomov@chromium.org,marja@chromium.org,conradw@chromium.org,rossberg@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:3956 Committed: https://crrev.com/1ea118d592ed5403ab01eb7fb008d41041a868f5 Cr-Commit-Position: refs/heads/master@{#28001}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+470 lines, -92 lines) Patch
M src/messages.js View 1 chunk +4 lines, -2 lines 0 comments Download
M src/parser.h View 3 chunks +4 lines, -7 lines 0 comments Download
M src/parser.cc View 8 chunks +62 lines, -29 lines 0 comments Download
M src/preparser.h View 13 chunks +167 lines, -27 lines 0 comments Download
M src/preparser.cc View 4 chunks +63 lines, -11 lines 0 comments Download
M test/cctest/test-parsing.cc View 2 chunks +113 lines, -16 lines 0 comments Download
M test/mjsunit/strong/classes.js View 3 chunks +57 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Michael Achenbach
Created Revert of Revert of [strong] checking of this & super in constructors
5 years, 8 months ago (2015-04-22 11:04:17 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1073103004/1
5 years, 8 months ago (2015-04-22 11:04:21 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-22 11:04:31 UTC) #3
commit-bot: I haz the power
5 years, 8 months ago (2015-04-22 13:19:28 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1ea118d592ed5403ab01eb7fb008d41041a868f5
Cr-Commit-Position: refs/heads/master@{#28001}

Powered by Google App Engine
This is Rietveld 408576698