Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(563)

Issue 1073083002: Make mksnapshot stats unambiguous for easier parsing. (Closed)

Created:
5 years, 8 months ago by Yang
Modified:
5 years, 8 months ago
Reviewers:
Michael Achenbach
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Make mksnapshot stats unambiguous for easier parsing. R=machenbach@chromium.org Committed: https://crrev.com/8d4bae91c9ad6feb13d91510d39b96074cd56d23 Cr-Commit-Position: refs/heads/master@{#27735}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/snapshot/snapshot-common.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (1 generated)
Yang
Example output is now: Deserialization will reserve: 830904 bytes per startup 197152 bytes per context ...
5 years, 8 months ago (2015-04-10 07:30:57 UTC) #1
Michael Achenbach
lgtm
5 years, 8 months ago (2015-04-10 08:41:58 UTC) #2
Yang
On 2015/04/10 07:30:57, Yang wrote: > Example output is now: > > Deserialization will reserve: ...
5 years, 8 months ago (2015-04-10 08:42:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1073083002/1
5 years, 8 months ago (2015-04-10 08:42:15 UTC) #5
Yang
Committed patchset #1 (id:1) manually as 8d4bae91c9ad6feb13d91510d39b96074cd56d23 (presubmit successful).
5 years, 8 months ago (2015-04-10 08:48:10 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-10 08:48:13 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8d4bae91c9ad6feb13d91510d39b96074cd56d23
Cr-Commit-Position: refs/heads/master@{#27735}

Powered by Google App Engine
This is Rietveld 408576698