Issue 1073063002: Reland "Get gn_all/gyp_remaining working for Windows."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1073063002: Reland "Get gn_all/gyp_remaining working for Windows." (Closed)

Created:
5 years, 8 months ago by Dirk Pranke

Modified:
5 years, 8 months ago

Reviewers:
brettw

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Reland "Get gn_all/gyp_remaining working for Windows." This patch re-lands commit eaef8f504d6e2a55626e2fb8b6c233f1d756d65c, https://codereview.chromium.org/1064333002/, with a fix for the Win x64 debug builder. TBR=brettw@chromium.org BUG=354261 Committed: https://crrev.com/6735641f97f15408d16a9ade94828c463a6fefec Cr-Commit-Position: refs/heads/master@{#324588}

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+174 lines, -61 lines)			Patch
	M	build/all.gyp	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	build/gn_migration.gypi	View	1	11 chunks	+173 lines, -60 lines	0 comments	Download

Total messages: 5 (1 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1073063002/20001

5 years, 8 months ago (2015-04-10 03:08:46 UTC) #3

commit-bot: I haz the power

5 years, 8 months ago (2015-04-10 04:40:08 UTC) #5

Message was sent while issue was closed.

Patchset 2 (id:??) landed as
https://crrev.com/6735641f97f15408d16a9ade94828c463a6fefec
Cr-Commit-Position: refs/heads/master@{#324588}