Issue 107303002: Make the TranslateInfoBarDelegate once again use the TranslateUIDelegate.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 107303002: Make the TranslateInfoBarDelegate once again use the TranslateUIDelegate. (Closed)

Created:
7 years ago by Peter Kasting

Modified:
7 years ago

Reviewers:
Miguel Garcia, hajimehoshi

CC:
chromium-reviews, droger, Miguel Garcia, Takashi Toyoshima

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Make the TranslateInfoBarDelegate once again use the TranslateUIDelegate. This is basically a revert of r234759. I realized that I can simply pass in an appropriate WebContents* to the TranslateInfoBarDelegate constructor, instead of waiting until web_contents() will return something non-NULL. I feel dumb for not thinking of this sooner. BUG=62154 TEST=none R=hajimehoshi@chromium.org, miguelg@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=239307

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+107 lines, -250 lines)			Patch
M	chrome/browser/translate/translate_browser_metrics.h	View	1 2	1 chunk	+0 lines, -8 lines	0 comments	Download
M	chrome/browser/translate/translate_browser_metrics.cc	View	1 2	2 chunks	+0 lines, -24 lines	0 comments	Download
M	chrome/browser/translate/translate_infobar_delegate.h	View	1 2	6 chunks	+15 lines, -29 lines	0 comments	Download
M	chrome/browser/translate/translate_infobar_delegate.cc	View	1 2	8 chunks	+23 lines, -111 lines	0 comments	Download
M	chrome/browser/translate/translate_manager_browsertest.cc	View	1 2	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/translate/translate_ui_delegate.h	View	1 2	5 chunks	+13 lines, -16 lines	0 comments	Download
M	chrome/browser/translate/translate_ui_delegate.cc	View	1 2	10 chunks	+50 lines, -57 lines	0 comments	Download
M	chrome/browser/ui/cocoa/infobars/translate_infobar_unittest.mm	View	1 2	2 chunks	+6 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Peter Kasting

7 years ago (2013-12-07 03:42:23 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as r239307 (presubmit successful).

Expand Messages | Collapse Messages